Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore BOM symbol when parsing GraphQL schema #2039

Merged
merged 1 commit into from
Mar 6, 2020
Merged

Ignore BOM symbol when parsing GraphQL schema #2039

merged 1 commit into from
Mar 6, 2020

Conversation

sav007
Copy link
Contributor

@sav007 sav007 commented Mar 6, 2020

Closes #2017

@sav007 sav007 self-assigned this Mar 6, 2020
@simonmarshall
Copy link

thanks @sav007
there was a bommed schema attached, if u need unit test data

@tasomaniac tasomaniac merged commit 53b70b6 into apollographql:hotfix/1.3.3 Mar 6, 2020
sav007 added a commit that referenced this pull request Mar 7, 2020
@tasomaniac @sav007
Merge Hotfix 1.3.3 into master (#2049)
e1b3795 
* Ignore BOM symbol when parsing GraphQL schema (#2039)

Closes #2017

* Fix issue when JSON object map to raw String it loses quotes (#2037)

* Fix issue when JSON object map to raw String it loses quotes

In case when JSON object / array is mapped to plain `String` call proper JSON serialization instead of `value.toString()`.

Also it appears that `UnmodifiableMapBuilder` doesn't preserve order that seem really odd.

Bump version to `1.3.3`

Closes #2012

* Revert version back

* Update apollo-api/src/main/java/com/apollographql/apollo/response/ScalarTypeAdapters.java

* Fix tests

Co-authored-by: Said Tahsin Dane <[email protected]>

* Fix issue with lowercase enum type names (#2045)

Closes #1901

* Change version to snapshot

* release 1.3.3

* version is now 1.3.4-SNAPSHOT

Co-authored-by: Ivan Savytskyi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinbonnin martinbonnin martinbonnin approved these changes

@tasomaniac tasomaniac tasomaniac approved these changes

Assignees

@sav007 sav007

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sav007 @simonmarshall @tasomaniac @martinbonnin