Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Download Pod Logs button not honouring argocd-server rootpath #6548

Closed
adeepsri opened this issue Jun 24, 2021 · 3 comments · Fixed by #6627
Closed

Download Pod Logs button not honouring argocd-server rootpath #6548

adeepsri opened this issue Jun 24, 2021 · 3 comments · Fixed by #6627
Labels
bug/priority:medium Should be fixed in the next minor releases bug/severity:minor Bug has limited impact, maybe affects only an edge-case or is of cosmetic nature bug Something isn't working component:ui User interfaces bugs and enhancements
Milestone
v2.1

Comments

@adeepsri
Copy link

adeepsri commented Jun 24, 2021 •
edited
Loading

Describe the bug
Clicking Download Pod Logs button redirects to baseurl without rootpath.

To Reproduce

  1. Create argocd-server deployment with command as:
    - command: - argocd-server - --staticassets - /shared/app - --redis - argocd-redis-ha-haproxy:6379 - --rootpath - /argocd_ - --insecure
  2. Go to one of the application and click on one of the Pods
  3. Click DOWNLOAD, it redirects to <baseurl> instead of <baseurl>/argocd_

Expected behavior

It should redirect to <baseurl>/argocd_ for download as well.

Screenshots
image
image

Version
Argocd v2.0.1
@adeepsri adeepsri added the bug Something isn't working label Jun 24, 2021
@jessesuen jessesuen added this to the v2.1 milestone Jun 24, 2021
@rbreeze rbreeze added the component:ui User interfaces bugs and enhancements label Jun 24, 2021
@jessesuen
Copy link
Member

Workaround is to click on link and add root path to URL.

@jannfis jannfis added bug/priority:medium Should be fixed in the next minor releases bug/severity:minor Bug has limited impact, maybe affects only an edge-case or is of cosmetic nature labels Jun 27, 2021
@adeepsri
Copy link
Author

@jessesuen @jannfis Can we please pick this on priority , because none of the pod logs are downloading when we use rootPath.

alexmt added a commit to alexmt/argo-cd that referenced this issue Jul 2, 2021
@alexmt
fix: download Pod Logs button not honouring argocd-server rootpath (a…
252488a 
…rgoproj#6548)

Signed-off-by: Alexander Matyushentsev <[email protected]>
@alexmt alexmt mentioned this issue Jul 2, 2021
Merged
@alexmt
Copy link
Collaborator

alexmt commented Jul 2, 2021

Created PR with the fix #6627 and will cherry-pick into 2.0

alexmt pushed a commit that referenced this issue Jul 12, 2021
fix: download Pod Logs button not honouring argocd-server rootpath (#…
dec710e 
…6548) (#6627)

Signed-off-by: Alexander Matyushentsev <[email protected]>
alexmt pushed a commit that referenced this issue Jul 22, 2021
@alexmt
fix: download Pod Logs button not honouring argocd-server rootpath (#…
eaa0c1e 
…6548) (#6627)

Signed-off-by: Alexander Matyushentsev <[email protected]>
@oisin88 oisin88 mentioned this issue Aug 2, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug/priority:medium Should be fixed in the next minor releases bug/severity:minor Bug has limited impact, maybe affects only an edge-case or is of cosmetic nature bug Something isn't working component:ui User interfaces bugs and enhancements
Projects
None yet
Milestone
v2.1
Development

Successfully merging a pull request may close this issue.

fix: download Pod Logs button not honouring argocd-server rootpath (#6548) alexmt/argo-cd
5 participants
@alexmt @jannfis @rbreeze @jessesuen @adeepsri