Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: download Pod Logs button not honouring argocd-server rootpath (#6548) #6627

Merged
merged 1 commit into from
Jul 12, 2021

Conversation

alexmt
Copy link
Collaborator

@alexmt alexmt commented Jul 2, 2021

Signed-off-by: Alexander Matyushentsev [email protected]

Closes #6548

@alexmt alexmt requested a review from rbreeze July 2, 2021 19:19
@alexmt alexmt self-assigned this Jul 2, 2021
@alexmt alexmt added this to the v2.1 milestone Jul 2, 2021
@alexmt alexmt added the cherry-pick/2.0 Candidate for cherry picking into the 2.0 release branch label Jul 2, 2021
@codecov
Copy link

codecov bot commented Jul 2, 2021

Codecov Report

Merging #6627 (252488a) into master (7149e35) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6627   +/-   ##
=======================================
  Coverage   41.29%   41.29%           
=======================================
  Files         156      156           
  Lines       20688    20688           
=======================================
  Hits         8543     8543           
  Misses      10937    10937           
  Partials     1208     1208           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7149e35...252488a. Read the comment docs.

@alexmt alexmt merged commit dec710e into argoproj:master Jul 12, 2021
@alexmt alexmt deleted the 6548-download-url branch July 12, 2021 16:09
@jannfis jannfis added the needs-verification PR requires pre-release verification label Jul 13, 2021
alexmt pushed a commit that referenced this pull request Jul 22, 2021
@alexmt alexmt removed the needs-verification PR requires pre-release verification label Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick/2.0 Candidate for cherry picking into the 2.0 release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Download Pod Logs button not honouring argocd-server rootpath
3 participants