Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NATS Event Source - Support NKEY Credentials #1050

Closed
cawfeecoder opened this issue Feb 3, 2021 · 1 comment · Fixed by #1052
Closed

NATS Event Source - Support NKEY Credentials #1050

cawfeecoder opened this issue Feb 3, 2021 · 1 comment · Fixed by #1052
Labels
enhancement New feature or request
Milestone

Comments

@cawfeecoder
Copy link

Is your feature request related to a problem? Please describe.
Currently, the NATS Event Source cannot connect to clusters that integrate with nats-account-server (to provision accounts that have particular permissions). I'd like to see the NATS Event Source Spec (and implementation) pick up the ability to pass a reference to a secret that contains a valid NATS .creds file

Describe the solution you'd like
I'd like to see the NATS Event Source expanded in order to accommodate clusters that accept NKEYs in the form of .creds to authenticate.

Describe alternatives you've considered
If this doesn't get fulfilled, I'll likely write a bridge from a auth enabled NATS cluster to send the message over HTTP POST to the Argo Events Webhook Event Source

Additional context
Add any other context or screenshots about the feature request here.


Message from the maintainers:

If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.

@cawfeecoder cawfeecoder added the enhancement New feature or request label Feb 3, 2021
@whynowy whynowy added this to the v1.3 milestone Feb 4, 2021
whynowy added a commit to whynowy/argo-events that referenced this issue Feb 5, 2021
whynowy added a commit that referenced this issue Feb 10, 2021
* feat(eventsource): Support NATS access with auth. Closes #1050

Signed-off-by: Derek Wang <[email protected]>

* refac

Signed-off-by: Derek Wang <[email protected]>

* update example

Signed-off-by: Derek Wang <[email protected]>

* re-run codegen

Signed-off-by: Derek Wang <[email protected]>
@whynowy
Copy link
Member

whynowy commented Feb 10, 2021

@nfrush - Would you like to do a testing? You need to use the latest installation manifests: https://raw.githubusercontent.com/argoproj/argo-events/master/manifests/install.yaml, and change the images to:

gcr.io/whynowy/sensor:2.096
gcr.io/whynowy/sensor-controller:2.096
gcr.io/whynowy/eventsource:2.096
gcr.io/whynowy/eventsource-controller:2.096
gcr.io/whynowy/eventbus-controller:2.096

juliev0 pushed a commit to juliev0/argo-events that referenced this issue Mar 29, 2022
argoproj#1052)

* feat(eventsource): Support NATS access with auth. Closes argoproj#1050

Signed-off-by: Derek Wang <[email protected]>

* refac

Signed-off-by: Derek Wang <[email protected]>

* update example

Signed-off-by: Derek Wang <[email protected]>

* re-run codegen

Signed-off-by: Derek Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants