feat(eventsource): Support NATS access with auth. Closes #1050 #1052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Wang <[email protected]>
Signed-off-by: Derek Wang <[email protected]>
Signed-off-by: Derek Wang <[email protected]>
whynowy
commented
Feb 5, 2021
| @@ -77,3 +84,68 @@ type EventBusType string | |||
| var ( | |||
| EventBusNATS EventBusType = "nats" | |||
| ) | |||
|
|
|||
There was a problem hiding this comment.
Nothing new here, just merged several tiny files into this one.
|
@VaibhavPage I'd love to see this get reviewed and merged in. I'll be happy to drive it for a test run :) |
juliev0
pushed a commit
to juliev0/argo-events
that referenced
this pull request
Mar 29, 2022
argoproj#1052) * feat(eventsource): Support NATS access with auth. Closes argoproj#1050 Signed-off-by: Derek Wang <[email protected]> * refac Signed-off-by: Derek Wang <[email protected]> * update example Signed-off-by: Derek Wang <[email protected]> * re-run codegen Signed-off-by: Derek Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Derek Wang [email protected]
Closes #1050
Checklist: