Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger conditions reset #1381

Closed
whynowy opened this issue Oct 18, 2021 · 1 comment · Fixed by #1392
Closed

Trigger conditions reset #1381

whynowy opened this issue Oct 18, 2021 · 1 comment · Fixed by #1392
Labels
enhancement New feature or request

Comments

@whynowy
Copy link
Member

whynowy commented Oct 18, 2021

Is your feature request related to a problem? Please describe.
When multiple trigger conditions are used (e.g. A && B), it's useful to be able to reset the conditions to refresh.

For example, conditions A is SQS messages, which is expected to come 1 time a day. B is a calendar type event source, which emits events at 8:00AM everyday. The SQS message could come at any time in a day, if everything works well, the trigger is going to be triggered either at 8:00AM, or anytime after 8:00AM, depends on when the SQS message comes. After the trigger is executed, the trigger conditions are reset. However, if there's anything wrong with the SQS source, which causes a message missed on a day, so the trigger conditions become previous days B waiting for todays A, then it could make the trigger to be executed anytime in a day.

Describe the solution you'd like
Give a conditionsReset field, which could be an array, that defines reset criteria. Reset criteria could be everydayAt, which give a value like 22:12:08.

Reset criteria could be extended in the future.


Message from the maintainers:

If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.

@whynowy whynowy added the enhancement New feature or request label Oct 18, 2021
@whynowy
Copy link
Member Author

whynowy commented Oct 18, 2021

Maybe supporting cron.

whynowy added a commit that referenced this issue Oct 26, 2021
* feat: trigger conditions reset

Signed-off-by: Derek Wang <[email protected]>
whynowy added a commit that referenced this issue Nov 8, 2021
* feat: trigger conditions reset

Signed-off-by: Derek Wang <[email protected]>
BulkBeing pushed a commit to BulkBeing/argo-events that referenced this issue Nov 16, 2021
* feat: trigger conditions reset

Signed-off-by: Derek Wang <[email protected]>
juliev0 pushed a commit to juliev0/argo-events that referenced this issue Mar 29, 2022
* feat: trigger conditions reset

Signed-off-by: Derek Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant