feat: trigger conditions reset. Closes #1381 #1392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Wang <[email protected]>
whynowy
changed the title
Signed-off-by: Derek Wang <[email protected]>
Signed-off-by: Derek Wang <[email protected]>
|
@whynowy Can you add examples of how to configure the resetCondition? |
👍 |
Signed-off-by: Derek Wang <[email protected]>
|
Here you go @sarabala1979 . |
Signed-off-by: Derek Wang <[email protected]>
Signed-off-by: Derek Wang <[email protected]>
Signed-off-by: Derek Wang <[email protected]>
| @@ -306,10 +304,17 @@ func (n *natsStreaming) processEventSourceMsg(m *stan.Msg, msgHolder *eventSourc | |||
| return | |||
| } | |||
| if result != true { | |||
| // Log current meet dependency information | |||
| @@ -18,6 +18,11 @@ spec: | |||
| - template: | |||
| # Boolean expression contains dependency names to determine whether to execute the trigger or not | |||
| conditions: "test-dep" | |||
| conditionsReset: | |||
| - byTime: | |||
| # Reset conditions at 23:59 everyday | |||
There was a problem hiding this comment.
Will condition reset below scenario?
- Sensor down at the scheduled time and restart after that.
- Sensor restart anytime
There was a problem hiding this comment.
Unfortunately, if the sensor is down at the time it is scheduled, it will miss the reset, but I don't think it's worth using persistence somehow. If this is a big concern for the users, they should increase the Sensor replicas to achieve HA.
sarabala1979
approved these changes
Oct 26, 2021
whynowy
added a commit
that referenced
this pull request
Nov 8, 2021
* feat: trigger conditions reset Signed-off-by: Derek Wang <[email protected]>
BulkBeing
pushed a commit
to BulkBeing/argo-events
that referenced
this pull request
Nov 16, 2021
* feat: trigger conditions reset Signed-off-by: Derek Wang <[email protected]>
juliev0
pushed a commit
to juliev0/argo-events
that referenced
this pull request
Mar 29, 2022
* feat: trigger conditions reset Signed-off-by: Derek Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Derek Wang [email protected]
Closes: #1381
Checklist: