Duplicate CRD for workflows causes id collision when deployed alongside argoproj/argo
#367
Comments
donoftime
pushed a commit
to donoftime/argo-events
that referenced
this issue
Oct 3, 2019
When `argoproj/argo-events` is installed alongside `argoproj/argo` via Kustomize, there is a collision between the workflow CRD defined by the argo project and the one which is duplicated in this project. An example of this issue in action would be a kustomization file which looks like this: ``` apiVersion: kustomize.config.k8s.io/v1beta1 kind: Kustomization bases: - github.com/argoproj/argo//manifests/cluster-install - github.com/argoproj/argo-events//hack/k8s/manifests/ ``` A `kustomize build` with that kustomization.yml results in the following error with kustomize v3.2.0: ``` Error: accumulating resources: recursed merging from path 'github.com/argoproj/argo-events//hack/k8s/manifests/': may not add resource with an already registered id: apiextensions.k8s.io_v1beta1_CustomResourceDefinition|~X|workflows.argoproj.io ``` This is due to both `argoproj/argo` and `argoproj/argo-events` defining a CRD for `workflows.argoproj.io`. Removing the reference to this CRD from the kustomization.yml in this project will allow both projects to be deployed alongside each other more easily with kustomize. The workflow CRD perhaps should be removed from this project entirely. This commit addresses the issue reported in argoproj#367
donoftime
added a commit
to donoftime/argo-events
that referenced
this issue
Oct 3, 2019
When `argoproj/argo-events` is installed alongside `argoproj/argo` via Kustomize, there is a collision between the workflow CRD defined by the argo project and the one which is duplicated in this project. An example of this issue in action would be a kustomization file which looks like this: ``` apiVersion: kustomize.config.k8s.io/v1beta1 kind: Kustomization bases: - github.com/argoproj/argo//manifests/cluster-install - github.com/argoproj/argo-events//hack/k8s/manifests/ ``` A `kustomize build` with that kustomization.yml results in the following error with kustomize v3.2.0: ``` Error: accumulating resources: recursed merging from path 'github.com/argoproj/argo-events//hack/k8s/manifests/': may not add resource with an already registered id: apiextensions.k8s.io_v1beta1_CustomResourceDefinition|~X|workflows.argoproj.io ``` This is due to both `argoproj/argo` and `argoproj/argo-events` defining a CRD for `workflows.argoproj.io`. Removing the reference to this CRD from the kustomization.yml in this project will allow both projects to be deployed alongside each other more easily with kustomize. The workflow CRD perhaps should be removed from this project entirely. This commit addresses the issue reported in argoproj#367
|
Thanks for #368 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
The CRD for
workflows.argoproj.iois duplicated in this project, causing a collision when deployed alongsideargoproj/argoTo Reproduce
When
argoproj/argo-eventsis installed alongsideargoproj/argovia Kustomize,there is a collision between the workflow CRD defined by the argo project
and the one which is duplicated in this project. An example of this
issue in action would be a kustomization file which looks like this:
A
kustomize buildwith that kustomization.yml results in the following error with kustomize v3.2.0:This is due to both
argoproj/argoandargoproj/argo-eventsdefining a CRD for
workflows.argoproj.io. Removing the reference to this CRDfrom the kustomization.yml in this project will allow both projects to be deployed
alongside each other more easily with kustomize. The workflow CRD
perhaps should be removed from this project entirely.
Expected behavior
A kustomization file referencing
argoproj/argoandargoproj/argo-eventsas bases can build successfully.The text was updated successfully, but these errors were encountered: