Omit duplicate CRD for workflows #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
When `argoproj/argo-events` is installed alongside `argoproj/argo` via Kustomize, there is a collision between the workflow CRD defined by the argo project and the one which is duplicated in this project. An example of this issue in action would be a kustomization file which looks like this: ``` apiVersion: kustomize.config.k8s.io/v1beta1 kind: Kustomization bases: - github.com/argoproj/argo//manifests/cluster-install - github.com/argoproj/argo-events//hack/k8s/manifests/ ``` A `kustomize build` with that kustomization.yml results in the following error with kustomize v3.2.0: ``` Error: accumulating resources: recursed merging from path 'github.com/argoproj/argo-events//hack/k8s/manifests/': may not add resource with an already registered id: apiextensions.k8s.io_v1beta1_CustomResourceDefinition|~X|workflows.argoproj.io ``` This is due to both `argoproj/argo` and `argoproj/argo-events` defining a CRD for `workflows.argoproj.io`. Removing the reference to this CRD from the kustomization.yml in this project will allow both projects to be deployed alongside each other more easily with kustomize. The workflow CRD perhaps should be removed from this project entirely. This commit addresses the issue reported in argoproj#367
donoftime
force-pushed
the
omit-duplicate-crd
branch
from
cd0fcf9 to
7ce6c7d
Compare
VaibhavPage
approved these changes
Oct 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
argoproj/argo-eventsis installed alongsideargoproj/argovia Kustomize,there is a collision between the workflow CRD defined by the argo project
and the one which is duplicated in this project. An example of this
issue in action would be a kustomization file which looks like this:
A
kustomize buildwith that kustomization.yml results in the following error with kustomize v3.2.0:This is due to both
argoproj/argoandargoproj/argo-eventsdefining a CRD for
workflows.argoproj.io. Removing the reference to this CRDfrom the kustomization.yml in this project will allow both projects to be deployed
alongside each other more easily with kustomize. The workflow CRD
perhaps should be removed from this project entirely.
This commit addresses the issue reported in #367