-
Notifications
You must be signed in to change notification settings - Fork 749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kafka trigger produces wrong timestamp #990
Comments
Did you set the kafka version like this: https://github.com/argoproj/argo-events/blob/master/examples/event-sources/kafka.yaml#L34 |
This happens when I use the Kafka trigger, not as an event source.
… Am 11.12.2020 um 20:43 schrieb Derek Wang ***@***.***>:
Did you set the kafka version like this: https://github.com/argoproj/argo-events/blob/master/examples/event-sources/kafka.yaml#L34
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
@mrkwtz - I see, thanks! A optional |
And we might default the version to 1.0.0, which is same as EventSource. |
Signed-off-by: Derek Wang <[email protected]>
Signed-off-by: Derek Wang <[email protected]>
Thanks, that would be awesome! :) |
* feat: ability to specify version in kafka trigger. Closes #990. Signed-off-by: Derek Wang <[email protected]> * upgrade slack version Signed-off-by: Derek Wang <[email protected]> * omitempty Signed-off-by: Derek Wang <[email protected]>
… (argoproj#991) * feat: ability to specify version in kafka trigger. Closes argoproj#990. Signed-off-by: Derek Wang <[email protected]> * upgrade slack version Signed-off-by: Derek Wang <[email protected]> * omitempty Signed-off-by: Derek Wang <[email protected]>
Describe the bug
When an event is pushed to kafka the associated timestamp is always "-1".
To Reproduce
Just connect any eventSource with a kafka trigger and consume the message via kafka-console-consumer. Your output is going to look like this
CreateTime:-1 {"message":"test"}
Expected behavior
A valid timestamp should be send to kafka.
Environment (please complete the following information):
Additional context
I guess this is the same problem: https://stackoverflow.com/questions/52704889/invalid-timestamp-when-writing-a-kafka-producer-with-sarama
Message from the maintainers:
If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.
The text was updated successfully, but these errors were encountered: