Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kafka trigger produces wrong timestamp #990

Closed
mrkwtz opened this issue Dec 11, 2020 · 5 comments · Fixed by #991
Closed

Kafka trigger produces wrong timestamp #990

mrkwtz opened this issue Dec 11, 2020 · 5 comments · Fixed by #991
Assignees
Labels
bug Something isn't working
Milestone

Comments

@mrkwtz
Copy link

mrkwtz commented Dec 11, 2020

Describe the bug
When an event is pushed to kafka the associated timestamp is always "-1".

To Reproduce
Just connect any eventSource with a kafka trigger and consume the message via kafka-console-consumer. Your output is going to look like this

CreateTime:-1 {"message":"test"}

Expected behavior
A valid timestamp should be send to kafka.

Environment (please complete the following information):

  • Kubernetes: v1.17.12
  • Argo Events: v1.1.0

Additional context
I guess this is the same problem: https://stackoverflow.com/questions/52704889/invalid-timestamp-when-writing-a-kafka-producer-with-sarama


Message from the maintainers:

If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.

@mrkwtz mrkwtz added the bug Something isn't working label Dec 11, 2020
@whynowy whynowy self-assigned this Dec 11, 2020
@whynowy
Copy link
Member

whynowy commented Dec 11, 2020

@mrkwtz
Copy link
Author

mrkwtz commented Dec 11, 2020 via email

@whynowy
Copy link
Member

whynowy commented Dec 11, 2020

@mrkwtz - I see, thanks! A optional version field should also be provided in the spec, does that sound good?

@whynowy
Copy link
Member

whynowy commented Dec 11, 2020

And we might default the version to 1.0.0, which is same as EventSource.

whynowy added a commit to whynowy/argo-events that referenced this issue Dec 12, 2020
whynowy added a commit to whynowy/argo-events that referenced this issue Dec 12, 2020
@mrkwtz
Copy link
Author

mrkwtz commented Dec 14, 2020

@mrkwtz - I see, thanks! A optional version field should also be provided in the spec, does that sound good?

Thanks, that would be awesome! :)

@whynowy whynowy added this to the v1.2 milestone Dec 14, 2020
whynowy added a commit that referenced this issue Dec 21, 2020
* feat: ability to specify version in kafka trigger. Closes #990.

Signed-off-by: Derek Wang <[email protected]>

* upgrade slack version

Signed-off-by: Derek Wang <[email protected]>

* omitempty

Signed-off-by: Derek Wang <[email protected]>
juliev0 pushed a commit to juliev0/argo-events that referenced this issue Mar 29, 2022
… (argoproj#991)

* feat: ability to specify version in kafka trigger. Closes argoproj#990.

Signed-off-by: Derek Wang <[email protected]>

* upgrade slack version

Signed-off-by: Derek Wang <[email protected]>

* omitempty

Signed-off-by: Derek Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants