feat: ability to specify version in kafka trigger. Closes #990. #991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Wang <[email protected]>
Signed-off-by: Derek Wang <[email protected]>
alexec
reviewed
Dec 21, 2020
pkg/apis/sensor/v1alpha1/types.go
Outdated
|
|
||
| // Specify what kafka version is being connected to enables certain features in sarama, defaults to 1.0.0 | ||
| // +optional | ||
| Version string `json:"version" protobuf:"bytes,11,opt,name=version"` |
There was a problem hiding this comment.
should be version,omitempty
alexec
reviewed
Dec 21, 2020
| @@ -49,6 +49,16 @@ func NewKafkaTrigger(sensor *v1alpha1.Sensor, trigger *v1alpha1.Trigger, kafkaPr | |||
| var err error | |||
| config := sarama.NewConfig() | |||
|
|
|||
| if kafkatrigger.Version == "" { | |||
There was a problem hiding this comment.
I'd add a kafkatrigger.GetVersion() (string, error)
There was a problem hiding this comment.
Dot not want to import sarama package into models.
Signed-off-by: Derek Wang <[email protected]>
alexec
approved these changes
Dec 21, 2020
This was referenced Dec 21, 2020
juliev0
pushed a commit
to juliev0/argo-events
that referenced
this pull request
Mar 29, 2022
… (argoproj#991) * feat: ability to specify version in kafka trigger. Closes argoproj#990. Signed-off-by: Derek Wang <[email protected]> * upgrade slack version Signed-off-by: Derek Wang <[email protected]> * omitempty Signed-off-by: Derek Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also defaults Kafka version to v1.0.0 which is the same as Kafka event source.
Closes #990.
Signed-off-by: Derek Wang [email protected]
Checklist: