feat: Adding Pulsar sensor #1356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whynowy
reviewed
Sep 23, 2021
There was a problem hiding this comment.
It's great to see a Pulsar trigger implementation, thanks for your contribution!
Would you like to come up with dome docs under https://github.com/argoproj/argo-events/tree/master/docs/sensors/triggers, it could be either in this PR, or a follow up one.
Signed-off-by: Arnar Gauti Ingason <[email protected]>
|
@whynowy I will create some documentation tomorrow :) |
Signed-off-by: Arnar Gauti Ingason <[email protected]>
|
I have added some docs for the Pulsar trigger. It's a copy of the Kafka trigger docs adapted to my new Pulsar one. |
1 task
aslafy-z
pushed a commit
to aslafy-z/argo-events
that referenced
this pull request
Oct 6, 2021
* feat: Adding Pulsar sensor Signed-off-by: Arnar Gauti Ingason <[email protected]> * feat: Adding Pulsar trigger documentation Signed-off-by: Arnar Gauti Ingason <[email protected]> Signed-off-by: GitHub <[email protected]>
juliev0
pushed a commit
to juliev0/argo-events
that referenced
this pull request
Mar 29, 2022
* feat: Adding Pulsar sensor Signed-off-by: Arnar Gauti Ingason <[email protected]> * feat: Adding Pulsar trigger documentation Signed-off-by: Arnar Gauti Ingason <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Adds a Pulsar sensor trigger so you can send messages to a Pulsar topic.