Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding support for token authentication in Pulsar EventSource #1359

Merged
merged 1 commit into from
Sep 24, 2021
Merged

feat: Adding support for token authentication in Pulsar EventSource #1359

merged 1 commit into from
Sep 24, 2021

Conversation

arnarg
Copy link
Contributor

@arnarg arnarg commented Sep 24, 2021

Checklist:

Adding an option to add an authentication token to Pulsar EventSource. This was already included in the Pulsar Trigger I contributed previously.

Copy link
Member

@whynowy whynowy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@whynowy whynowy merged commit 42fe43e into argoproj:master Sep 24, 2021
@arnarg arnarg deleted the pulsar-eventsource-auth branch September 24, 2021 17:52
aslafy-z pushed a commit to aslafy-z/argo-events that referenced this pull request Oct 6, 2021
juliev0 pushed a commit to juliev0/argo-events that referenced this pull request Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants