-
Notifications
You must be signed in to change notification settings - Fork 748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: do not overwrite the entrypoint of nats-server-config-reloader #3004
Conversation
4617ae6
to
2a5c69c
Compare
You need to sign off on your commits. Running
|
Signed-off-by: Yulin Li <[email protected]>
Signed-off-by: Yulin Li <[email protected]>
ab87c71
to
6fb324f
Compare
Thanks for reminder, I signed the commit off |
Signed-off-by: Yulin Li <[email protected]>
Signed-off-by: Yulin Li <[email protected]>
@@ -151,7 +151,7 @@ docs/assets/diagram.png: go-diagrams/diagram.dot | |||
.PHONY: start | |||
start: image | |||
kubectl apply -f test/manifests/argo-events-ns.yaml | |||
kubectl kustomize test/manifests | sed '[email protected]/argoproj/@$(IMAGE_NAMESPACE)/@' | sed 's/:$(BASE_VERSION)/:$(VERSION)/' | kubectl -n argo-events apply -l app.kubernetes.io/part-of=argo-events --prune=false --force -f - | |||
kubectl kustomize test/manifests | sed '[email protected]/argoproj/@$(IMAGE_NAMESPACE)/@' | sed 's/argo-events:$(BASE_VERSION)/argo-events:$(VERSION)/' | kubectl -n argo-events apply -l app.kubernetes.io/part-of=argo-events --prune=false --force -f - |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand this will make it more accurate, just curious, did you see any issue caused by not having argo-events
in the script?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, the natsio/nats-server-config-reloader:latest
was replaced to natsio/nats-server-config-reloader:<id>
in the tests, then the tests failed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
…3004) Signed-off-by: Yulin Li <[email protected]> Co-authored-by: Yulin Li <[email protected]>
Checklist:
To support
distroless
basednats-server-config-reloader
docker imageThe
natsio/nats-server-config-reloader
image should be >=0.9.0
now