Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not overwrite the entrypoint of nats-server-config-reloader #3004

Merged
merged 8 commits into from
Feb 19, 2024
Merged

fix: do not overwrite the entrypoint of nats-server-config-reloader #3004

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c6b274c
fix: do not overwrite the entrypoint of nats-server-config-reloader
Feb 2, 2024
6fb324f
bump up natsio/nats-server-config-reloader version
Feb 2, 2024
33d7980
bump to latest
Feb 3, 2024
4ceae41
only replace argo-events image tag
Feb 3, 2024
2c02a10
Merge branch 'master' into yulin/command-to-arg
yulin-li Feb 4, 2024
7988d8e
Merge branch 'master' into yulin/command-to-arg
yulin-li Feb 16, 2024
a708626
address comments
Feb 16, 2024
084a11f
Merge branch 'master' into yulin/command-to-arg
yulin-li Feb 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion controllers/eventbus/installer/jetstream.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,7 +401,7 @@ func (r *jetStreamInstaller) buildStatefulSetSpec(jsVersion *controllers.JetStre
Image: jsVersion.ConfigReloaderImage,
ImagePullPolicy: reloaderContainerPullPolicy,
SecurityContext: reloaderContainerSecurityContext,
Command: []string{"nats-server-config-reloader", "-pid", "/var/run/nats/nats.pid", "-config", "/etc/nats-config/nats-js.conf"},
Args: []string{"-pid", "/var/run/nats/nats.pid", "-config", "/etc/nats-config/nats-js.conf"},
VolumeMounts: []corev1.VolumeMount{
{Name: "config-volume", MountPath: "/etc/nats-config"},
{Name: "pid", MountPath: "/var/run/nats"},
Expand Down
16 changes: 8 additions & 8 deletions manifests/base/controller-manager/controller-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,40 +30,40 @@ data:
- version: latest
natsImage: nats:2.9.16
metricsExporterImage: natsio/prometheus-nats-exporter:0.9.1
configReloaderImage: natsio/nats-server-config-reloader:0.7.0
configReloaderImage: natsio/nats-server-config-reloader:0.14.1
startCommand: /nats-server
- version: 2.8.1
natsImage: nats:2.8.1
metricsExporterImage: natsio/prometheus-nats-exporter:0.9.1
configReloaderImage: natsio/nats-server-config-reloader:0.7.0
configReloaderImage: natsio/nats-server-config-reloader:0.14.1
startCommand: /nats-server
- version: 2.8.1-alpine
natsImage: nats:2.8.1-alpine
metricsExporterImage: natsio/prometheus-nats-exporter:0.9.1
configReloaderImage: natsio/nats-server-config-reloader:0.7.0
configReloaderImage: natsio/nats-server-config-reloader:0.14.1
startCommand: nats-server
- version: 2.8.2
natsImage: nats:2.8.2
metricsExporterImage: natsio/prometheus-nats-exporter:0.9.1
configReloaderImage: natsio/nats-server-config-reloader:0.7.0
configReloaderImage: natsio/nats-server-config-reloader:0.14.1
startCommand: /nats-server
- version: 2.8.2-alpine
natsImage: nats:2.8.2-alpine
metricsExporterImage: natsio/prometheus-nats-exporter:0.9.1
configReloaderImage: natsio/nats-server-config-reloader:0.7.0
configReloaderImage: natsio/nats-server-config-reloader:0.14.1
startCommand: nats-server
- version: 2.9.1
natsImage: nats:2.9.1
metricsExporterImage: natsio/prometheus-nats-exporter:0.9.1
configReloaderImage: natsio/nats-server-config-reloader:0.7.0
configReloaderImage: natsio/nats-server-config-reloader:0.14.1
startCommand: /nats-server
- version: 2.9.12
natsImage: nats:2.9.12
metricsExporterImage: natsio/prometheus-nats-exporter:0.9.1
configReloaderImage: natsio/nats-server-config-reloader:0.7.0
configReloaderImage: natsio/nats-server-config-reloader:0.14.1
startCommand: /nats-server
- version: 2.9.16
natsImage: nats:2.9.16
metricsExporterImage: natsio/prometheus-nats-exporter:0.9.1
configReloaderImage: natsio/nats-server-config-reloader:0.7.0
configReloaderImage: natsio/nats-server-config-reloader:0.14.1
startCommand: /nats-server
16 changes: 8 additions & 8 deletions manifests/install.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,42 +334,42 @@ data:
- version: latest
natsImage: nats:2.9.16
metricsExporterImage: natsio/prometheus-nats-exporter:0.9.1
configReloaderImage: natsio/nats-server-config-reloader:0.7.0
configReloaderImage: natsio/nats-server-config-reloader:0.14.1
startCommand: /nats-server
- version: 2.8.1
natsImage: nats:2.8.1
metricsExporterImage: natsio/prometheus-nats-exporter:0.9.1
configReloaderImage: natsio/nats-server-config-reloader:0.7.0
configReloaderImage: natsio/nats-server-config-reloader:0.14.1
startCommand: /nats-server
- version: 2.8.1-alpine
natsImage: nats:2.8.1-alpine
metricsExporterImage: natsio/prometheus-nats-exporter:0.9.1
configReloaderImage: natsio/nats-server-config-reloader:0.7.0
configReloaderImage: natsio/nats-server-config-reloader:0.14.1
startCommand: nats-server
- version: 2.8.2
natsImage: nats:2.8.2
metricsExporterImage: natsio/prometheus-nats-exporter:0.9.1
configReloaderImage: natsio/nats-server-config-reloader:0.7.0
configReloaderImage: natsio/nats-server-config-reloader:0.14.1
startCommand: /nats-server
- version: 2.8.2-alpine
natsImage: nats:2.8.2-alpine
metricsExporterImage: natsio/prometheus-nats-exporter:0.9.1
configReloaderImage: natsio/nats-server-config-reloader:0.7.0
configReloaderImage: natsio/nats-server-config-reloader:0.14.1
startCommand: nats-server
- version: 2.9.1
natsImage: nats:2.9.1
metricsExporterImage: natsio/prometheus-nats-exporter:0.9.1
configReloaderImage: natsio/nats-server-config-reloader:0.7.0
configReloaderImage: natsio/nats-server-config-reloader:0.14.1
startCommand: /nats-server
- version: 2.9.12
natsImage: nats:2.9.12
metricsExporterImage: natsio/prometheus-nats-exporter:0.9.1
configReloaderImage: natsio/nats-server-config-reloader:0.7.0
configReloaderImage: natsio/nats-server-config-reloader:0.14.1
startCommand: /nats-server
- version: 2.9.16
natsImage: nats:2.9.16
metricsExporterImage: natsio/prometheus-nats-exporter:0.9.1
configReloaderImage: natsio/nats-server-config-reloader:0.7.0
configReloaderImage: natsio/nats-server-config-reloader:0.14.1
startCommand: /nats-server
kind: ConfigMap
metadata:
Expand Down
16 changes: 8 additions & 8 deletions manifests/namespace-install.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,42 +254,42 @@ data:
- version: latest
natsImage: nats:2.9.16
metricsExporterImage: natsio/prometheus-nats-exporter:0.9.1
configReloaderImage: natsio/nats-server-config-reloader:0.7.0
configReloaderImage: natsio/nats-server-config-reloader:0.14.1
startCommand: /nats-server
- version: 2.8.1
natsImage: nats:2.8.1
metricsExporterImage: natsio/prometheus-nats-exporter:0.9.1
configReloaderImage: natsio/nats-server-config-reloader:0.7.0
configReloaderImage: natsio/nats-server-config-reloader:0.14.1
startCommand: /nats-server
- version: 2.8.1-alpine
natsImage: nats:2.8.1-alpine
metricsExporterImage: natsio/prometheus-nats-exporter:0.9.1
configReloaderImage: natsio/nats-server-config-reloader:0.7.0
configReloaderImage: natsio/nats-server-config-reloader:0.14.1
startCommand: nats-server
- version: 2.8.2
natsImage: nats:2.8.2
metricsExporterImage: natsio/prometheus-nats-exporter:0.9.1
configReloaderImage: natsio/nats-server-config-reloader:0.7.0
configReloaderImage: natsio/nats-server-config-reloader:0.14.1
startCommand: /nats-server
- version: 2.8.2-alpine
natsImage: nats:2.8.2-alpine
metricsExporterImage: natsio/prometheus-nats-exporter:0.9.1
configReloaderImage: natsio/nats-server-config-reloader:0.7.0
configReloaderImage: natsio/nats-server-config-reloader:0.14.1
startCommand: nats-server
- version: 2.9.1
natsImage: nats:2.9.1
metricsExporterImage: natsio/prometheus-nats-exporter:0.9.1
configReloaderImage: natsio/nats-server-config-reloader:0.7.0
configReloaderImage: natsio/nats-server-config-reloader:0.14.1
startCommand: /nats-server
- version: 2.9.12
natsImage: nats:2.9.12
metricsExporterImage: natsio/prometheus-nats-exporter:0.9.1
configReloaderImage: natsio/nats-server-config-reloader:0.7.0
configReloaderImage: natsio/nats-server-config-reloader:0.14.1
startCommand: /nats-server
- version: 2.9.16
natsImage: nats:2.9.16
metricsExporterImage: natsio/prometheus-nats-exporter:0.9.1
configReloaderImage: natsio/nats-server-config-reloader:0.7.0
yulin-li marked this conversation as resolved.
Show resolved Hide resolved
configReloaderImage: natsio/nats-server-config-reloader:0.14.1
startCommand: /nats-server
kind: ConfigMap
metadata:
Expand Down
Loading