Optional use QueueSubscribe for NATS events source #3131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sysr9
changed the title
|
Wouldn't it make more sense to make this the default, and switch the active-active failover? |
in some cases this may cause unpredictable effects
|
|
@sysr9 makes sense, if we are using the QueueGroup how can we make it use active-active HA mode? Or should that be a different PR? |
in my setup i have global NATS bus and multiple clusters with argo events deployed, now i need global events for all clusters |
whynowy
reviewed
May 20, 2024
| // Queue is the name of the queue group to subscribe as if specified. Uses QueueSubscribe | ||
| // logic to subscribe as queue group. If the queue is empty, uses default Subscribe logic. | ||
| // +optional | ||
| Queue string `json:"queue" protobuf:"bytes,9,opt,name=queue"` |
There was a problem hiding this comment.
Use *string, all the rest looks good to me, thanks!
Signed-off-by: sysr9 <[email protected]>
Signed-off-by: sysr9 <[email protected]>
Signed-off-by: sysr9 <[email protected]>
Signed-off-by: sysr9 <[email protected]>
Signed-off-by: sysr9 <[email protected]>
…1.0 (argoproj#3138) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: sysr9 <[email protected]>
…rgoproj#3139) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: sysr9 <[email protected]>
…proj#3140) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: sysr9 <[email protected]>
…goproj#3141) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: sysr9 <[email protected]>
Signed-off-by: sysr9 <[email protected]>
…goproj#3113) Signed-off-by: florian-feicht <[email protected]> Signed-off-by: sysr9 <[email protected]>
Signed-off-by: sysr9 <[email protected]>
whynowy
pushed a commit
that referenced
this pull request
Jun 14, 2024
Signed-off-by: sysr9 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2936
Checklist:
adds queue parameter to NATS EventSource to implement queue-based architecture