fix(argo-rollouts): Removed preserveUnknownFields from the CRD(s) whi… #923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaviolemos78
force-pushed
the
master
branch
3 times, most recently
from
8b6696a to
3456058
Compare
…ch is disallowed on the v1 API Signed-off-by: Flavio Lemos <[email protected]>
flaviolemos78
force-pushed
the
master
branch
from
3456058 to
82fdaab
Compare
|
I'd keep this as long as the upstream project (our sibling project) uses this: https://github.com/argoproj/argo-rollouts/tree/v1.0.2/manifests/crds Can you open an issue or PR over there? |
Created PR on the upstream project to ensure consistency: argoproj/argo-rollouts#1524 |
|
Upstream project is keeping the property to allow smooth transitions between v1beta into v1 api versions. Eventually it will be removed. Closing this PR until upstream deletes the property |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed preserveUnknownFields from the CRD(s) which is disallowed on the v1 API (https://kubernetes.io/docs/reference/using-api/deprecation-guide/#customresourcedefinition-v122)
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
Changes are automatically published when merged to
master. They are not published on branches.