Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(manifests): Removed preserveUnknownFields from the CRD(s) which is disallowe… #1524

Conversation

flaviolemos78
Copy link
Contributor

@flaviolemos78 flaviolemos78 commented Sep 20, 2021

Removed preserveUnknownFields from the CRD(s) which is disallowed on the v1 API (https://kubernetes.io/docs/reference/using-api/deprecation-guide/#customresourcedefinition-v122)

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@flaviolemos78 flaviolemos78 force-pushed the fix/remove-preserveUnknownFields branch from 0e15746 to cddb52f Compare September 20, 2021 15:04
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jessesuen
Copy link
Member

jessesuen commented Sep 20, 2021

This was actually intentionally left because we need to provide an upgrade path from older rollout versions. It's still premature to remove this field because people upgrading will not be able to upgrade without problems. There is an issue for tracking when we can remove this:

#1272 (comment)

@flaviolemos78 flaviolemos78 deleted the fix/remove-preserveUnknownFields branch September 21, 2021 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants