Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Remove non-Emissary executors #7930

Closed
wants to merge 6 commits into from
Closed

feat!: Remove non-Emissary executors #7930

wants to merge 6 commits into from

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Feb 18, 2022

Signed-off-by: Alex Collins [email protected]

Proof-of-concept to explore the impact of these changes.

@alexec
feat!: Remove non-Emissary executors
cfde329 
Signed-off-by: Alex Collins <[email protected]>
@alexec
chore: ok
7291674 
Signed-off-by: Alex Collins <[email protected]>
@alexec
fix: ok
6a8f710 
Signed-off-by: Alex Collins <[email protected]>
@alexec
fix: ok
85193b9 
Signed-off-by: Alex Collins <[email protected]>
@alexec
fix: ok
9626f3f 
Signed-off-by: Alex Collins <[email protected]>
@alexec
fix: ok
50da09c 
Signed-off-by: Alex Collins <[email protected]>
@alexec alexec closed this Feb 21, 2022
@terrytangyuan
Copy link
Member

Any findings?

@alexec
Copy link
Contributor Author

alexec commented Feb 22, 2022

Two

  • It was not as hard as I expected it to be. Which is good news.
  • I think we can remove the pod patch permission, by using the Taskset to send data back to the controller.

@terrytangyuan terrytangyuan mentioned this pull request Feb 22, 2022
Closed
4 tasks
@alexec alexec deleted the dev-em branch March 20, 2022 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexec @terrytangyuan