Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Split out executor/agent roles in quick-start RBAC. #7999

Merged
merged 11 commits into from
Feb 25, 2022

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Feb 24, 2022

Signed-off-by: Alex Collins [email protected]

The aim of this PR is to discourage excessive permissioning of workflows, as well as make it very clear what permissions each executor needs.

TODO:

  • fix spelling
  • search for workflow-role.yaml links and update them

Signed-off-by: Alex Collins <[email protected]>
Signed-off-by: Alex Collins <[email protected]>
Signed-off-by: Alex Collins <[email protected]>
@alexec alexec marked this pull request as ready for review February 25, 2022 02:38
@alexec alexec enabled auto-merge (squash) February 25, 2022 02:38
Signed-off-by: Alex Collins <[email protected]>
Signed-off-by: Alex Collins <[email protected]>
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the split. This will make #7829 easier since we know what permissions to get rid of when removing a particular executor.

docs/workflow-rbac.md Outdated Show resolved Hide resolved
docs/workflow-rbac.md Outdated Show resolved Hide resolved
Signed-off-by: Alex Collins <[email protected]>
Signed-off-by: Alex Collins <[email protected]>
Signed-off-by: Alex Collins <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants