fix: aborted requests should not clear its cache afterwards if previous request was cached (#922) #923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wykks
force-pushed
the
cancel-keep-cache
branch
2 times, most recently
from
0a82005 to
c75b493
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #923 +/- ##
=======================================
Coverage 99.59% 99.60%
=======================================
Files 19 19
Lines 2498 2509 +11
Branches 219 223 +4
=======================================
+ Hits 2488 2499 +11
Misses 10 10 ☔ View full report in Codecov by Sentry. |
Wykks
force-pushed
the
cancel-keep-cache
branch
from
c75b493 to
ab1fe3b
Compare
Wykks
changed the title
arthurfiorette
requested changes
Oct 21, 2024
|
overall, good work! |
Wykks
force-pushed
the
cancel-keep-cache
branch
from
ab1fe3b to
b1b3329
Compare
arthurfiorette
requested changes
Oct 21, 2024
Wykks
force-pushed
the
cancel-keep-cache
branch
3 times, most recently
from
1b54d9f to
cecad5a
Compare
…us request was cached (arthurfiorette#922)
Wykks
force-pushed
the
cancel-keep-cache
branch
from
cecad5a to
de11ef5
Compare
arthurfiorette
approved these changes
Oct 22, 2024
|
thanks for your work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not super convinced with the quality of the fix, but since it's a special case, maybe it's okay like that.
Ref: #922