Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MX-462] - Disable idfa access by Facebook sdk #3809

Merged
merged 4 commits into from
Sep 1, 2020
Merged

[MX-462] - Disable idfa access by Facebook sdk #3809

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a2ac79b
Remove idfa access from admin menu
brainbicycle Sep 1, 2020
39beba0
Update facebook sdk, disable access to idfa
brainbicycle Sep 1, 2020
f3c8ad0
updated facebook sdk
MounirDhahri Aug 20, 2020
52f2d70
Merge branch 'master' into brian/facebook-idfa
brainbicycle Sep 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Artsy/App_Resources/Artsy-Info.plist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,8 @@
<string>308278682573501</string>
<key>FacebookDisplayName</key>
<string>Artsy</string>
<key>FacebookAdvertiserIDCollectionEnabled</key>
<false/>
<key>GITCommitRev</key>
<string>4f76194c</string>
<key>GITCommitSha</key>
Expand Down
13 changes: 1 addition & 12 deletions Artsy/View_Controllers/Admin/ARAdminSettingsViewController.m
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
#import <MobileCoreServices/MobileCoreServices.h>
#import <ReplayKit/ReplayKit.h>
#import <AdSupport/ASIdentifierManager.h>

#import "ARAdminSettingsViewController.h"
#import "AREchoContentsViewController.h"
Expand Down Expand Up @@ -86,8 +85,7 @@ - (void)viewDidLoad

ARSectionData *toggleSections = [[ARSectionData alloc] initWithCellDataArray:@[
[self generateOnScreenAnalytics],
[self generateOnScreenMartsy],
[self copyAdvertisingID]
[self generateOnScreenMartsy]
]];
toggleSections.headerTitle = @"Options";
[tableViewData addSectionData:toggleSections];
Expand Down Expand Up @@ -144,15 +142,6 @@ - (ARCellData *)generateRestart
}];
}

- (ARCellData *)copyAdvertisingID
{
return [self tappableCellDataWithTitle:@"Copy Advertising ID" selectionWithCell:^(UITableViewCell *cell) {
NSUUID *adId = [[ASIdentifierManager sharedManager] advertisingIdentifier];
[[UIPasteboard generalPasteboard] setValue:[adId UUIDString] forPasteboardType:(NSString *)kUTTypePlainText];
cell.textLabel.text = @"Copied";
}];
}

- (ARCellData *)generateStagingSwitch
{
BOOL useStaging = [AROptions boolForOption:ARUseStagingDefault];
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ upcoming:
- Fix deep link handling edge case - david
- Connects new My Bids view to causality's lot standings - erik
- Removes AFNetworking/UIKit subspec - ash
- Disable facebook access to idfa - brian
user_facing:
- Fix shows save button - mounir
- Fix hidden slider handle bug in refine - brian
Expand Down
22 changes: 11 additions & 11 deletions Podfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,12 @@ PODS:
- "Artsy+UIColors (~> 3.0)"
- "Artsy+UIFonts"
- "UIView+BooleanAnimations"
- Bolts (1.9.0):
- Bolts/AppLinks (= 1.9.0)
- Bolts/Tasks (= 1.9.0)
- Bolts/AppLinks (1.9.0):
- Bolts (1.9.1):
- Bolts/AppLinks (= 1.9.1)
- Bolts/Tasks (= 1.9.1)
- Bolts/AppLinks (1.9.1):
- Bolts/Tasks
- Bolts/Tasks (1.9.0)
- Bolts/Tasks (1.9.1)
- boost-for-react-native (1.63.0)
- BVLinearGradient (2.5.6):
- React
Expand Down Expand Up @@ -118,9 +118,9 @@ PODS:
- React-Core (= 0.62.1)
- React-jsi (= 0.62.1)
- ReactCommon/turbomodule/core (= 0.62.1)
- FBSDKCoreKit (4.37.0):
- Bolts (~> 1.7)
- FBSDKLoginKit (4.37.0):
- FBSDKCoreKit (4.44.1):
- Bolts (~> 1.9)
- FBSDKLoginKit (4.44.1):
- FBSDKCoreKit
- FBSnapshotTestCase (2.1.4):
- FBSnapshotTestCase/SwiftSupport (= 2.1.4)
Expand Down Expand Up @@ -771,7 +771,7 @@ SPEC CHECKSUMS:
"Artsy+UIFonts": 597c44f264aead6bdc21898b690addd90e14edbd
"Artsy+UILabels": 7cb6e290a4f70dddba037b7dbeb21e90b49d7275
Artsy-UIButtons: 3c396f0fad352a7b0332100e0ffcb0ca577e0082
Bolts: ac6567323eac61e203f6a9763667d0f711be34c8
Bolts: 8c1e8aab2f603387b8b9924f57d1d64f43d3ffdc
boost-for-react-native: 39c7adb57c4e60d6c5479dd8623128eb5b3f0f2c
BVLinearGradient: e3aad03778a456d77928f594a649e96995f1c872
CocoaLumberjack: 27ae9abcd376c3e4ee726ecd4adfd7b093ddef3f
Expand All @@ -784,8 +784,8 @@ SPEC CHECKSUMS:
Extraction: 2be993a17f8f8c4fac988ebecaed93a409181faf
FBLazyVector: 95ee3e58937a6052f86b0e32f142388c22fa22c5
FBReactNativeSpec: 26dd6459299e48cd64eb397c45635e466dba9f45
FBSDKCoreKit: fe5f3474499a81963e11e3f3a5c753d0a95ca2b4
FBSDKLoginKit: 2f7249686d1e30ce8a5ef5400eedf50b3e3df332
FBSDKCoreKit: a823ae35bdb60ebb8d7a7e51abe7c5d87d2bfced
FBSDKLoginKit: 54ae59987f2a8703021557c90a9aebb9e5c2bef6
FBSnapshotTestCase: 094f9f314decbabe373b87cc339bea235a63e07a
FLKAutoLayout: 106b14dbae09d32c6730190f4e78a959759ba4a4
Folly: 30e7936e1c45c08d884aa59369ed951a8e68cf51
Expand Down