Support remote includes for PDF export #739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggrossetie
reviewed
Jul 2, 2023
CHANGELOG.md
Outdated
| @@ -5,6 +5,7 @@ | |||
| ### Improvements | |||
|
|
|||
| - provide folding for list of sibling attributes by @apupier (#719) | |||
| - support remote includes when exporting in PDF (#731) | |||
There was a problem hiding this comment.
Since we can add additional command line arguments, I guess we should say: "by default, allow remote includes when exporting in PDF"?
There was a problem hiding this comment.
with current implementation, it is not only by default. The parameter is always provided. The parameter from the settings are appended, they are not replacing some parameters that are always passed.
There was a problem hiding this comment.
Sorry I wasn't clear.
My point was that we already support remote includes when exporting in PDF since we can set -a allow-uri-read in the extension settings. I was suggesting to reword the changelog to mention that remote includes are now enabled by default when exporting to PDF.
part of asciidoctor#731 Signed-off-by: Aurélien Pupier <[email protected]>
apupier
force-pushed
the
731-supportRemoteIncludeForExportToPDF
branch
from
a613227 to
738174f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #731
exportPdfWithRemote.mp4