Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support remote includes for PDF export #739

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
### Improvements

- provide folding for list of sibling attributes by @apupier (#719)
- support remote includes when exporting in PDF without additional setting configuration (#731)

### Bug fixes

Expand Down
2 changes: 2 additions & 0 deletions src/commands/exportAsPDF.ts
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,8 @@ ${text}`
`"${baseDirectory.replace('"', '\\"')}"`, // base directory
'-o',
`"${pdfOutputPath.replace('"', '\\"')}"`, // output file
'-a',
'allow-uri-read',
]
const args = defaultArgs.concat(asciidoctorPdfCommandArgs)
.concat(['-']) // read from stdin
Expand Down