Test files should not be pulled into builds

[mduvergey]

Hi,

Installing NSubstitute with Unity package manager is required in order for Fluid Behavior Tree to compile properly.

Installation guidelines should mention that.

Best regards

[ashblue]

This should only be required if you're trying to run the test suite (at that point I highly suggest cloning down this repo instead) or you manually pulled the files into your project. How did you install the package? Hopefully you used the guide here?

https://github.com/ashblue/fluid-behavior-tree#installing

[mduvergey]

I installed the package following guide instructions, adding scopedRegistries entry in file manifest.json then using Unity Package Manager to get the package.

[ashblue]

Weird, haven't seen this before. Wondering if you somehow included the test files with your asmdef files. I'll try to reproduce on my end this weekend. What's your Unity version?

[mduvergey]

It's 2018.4.22f1.

[ashblue]

Uh oh, I think this package is marked as 2019 required at least. Big changes to the package manager since then. I'll update the install docs if this is the case.

[ashblue]

Okay min is 2018.1, will investigate and update more here this weekend https://github.com/ashblue/fluid-behavior-tree/blob/master/Assets/FluidBehaviorTree/package.json#L6

[ashblue]

A fresh install of 2019.3.15f1 with the library works fine. Proceeding to check 2018.4.22f1 to see if I can reproduce.

[ashblue]

@mduvergey I tried your specific version and I can't reproduce this issue. Can you post the specific error message? I think it may be something specific to your setup. Are you using .asmdef files? If so don't include any of the test ones.

[mduvergey]

Here is the error message:
Library/PackageCache/[email protected]/Tests/Editor/BehaviorTrees/BehaviorTreeTest.cs(6,7): error CS0246: The type or namespace name 'NSubstitute' could not be found (are you missing a using directive or an assembly reference?)

I'm not using .asmdef files.

One interesting thing I just found out is that the problem occurs with version 2.2.1 of Fluid BT but not with version 2.2.0.

[ashblue]

That gives me an idea, going to try fiddling with some settings.

[ashblue]

Yep, able to confirm, I'll try to get this patched asap.

[ashblue]

I found the issue. Looks like the editor test file was mangled on Unity upgrade. v2.2.0...v2.2.1#diff-0fe051f82fee31b8860f0c4d27fce39a

[ashblue]

Heyo, I got a fix into the nightly build which seems to be working fine. If you have some time you can try it out here (no pressure though).

https://github.com/ashblue/fluid-behavior-tree#nightly-builds

This will go out in the next release. I need to fix another bug with composites. Once that's done the two should go out together in a patch.

PS Thank you super duper much for your patience with reporting this. Will add you as a contributor for the stellar bug report.

[ashblue]

@all-contributors please add mduvergey for bug

[allcontributors]

@ashblue

I've put up a pull request to add @mduvergey! 🎉

[mduvergey]

Hi,
I can confirm that your fix works.
Thanks!