Diff is reversed

[bluthej]

Issue

The diff output is reversed since #7813.

For example, if I give ruff the following input file:

from .logging import config_logging
from .settings import ENV
from .settings import *

then I get the following correct output with v0.0.292:

--- test.py
+++ test.py
@@ -1,3 +1,3 @@
 from .logging import config_logging
+from .settings import *
 from .settings import ENV
-from .settings import *

Would fix 1 error.

But with the main branch, I get:

--- test.py
+++ test.py
@@ -1,3 +1,3 @@
 from .logging import config_logging
+from .settings import ENV
 from .settings import *
-from .settings import ENV

Would fix 1 error.

Fix

I traced it back to this line, where the old and new source files are reversed. It should read:

let text_diff = TextDiff::from_lines(src, dst);

If that's ok, I can submit a quick PR to fix it. There are 2 tests whose snapshot needs to be updated as a consequence, but apart from that the only change needed is the one I mentioned above.

[zanieb]

Thanks! I wonder how that pull request didn't change any snapshots

[charliermarsh]

Oops, PR welcome, thank you.

[bluthej]

@zanieb it seems like there are only two integration tests that test the output of the CLI diff option (diff_shows_safe_fixes_by_default and diff_shows_unsafe_fixes_with_opt_in), and they were added in #7769, which was merged 2 days after #7813 ^^