Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move diffing logic into SourceKind::diff #7813

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Move diffing logic into SourceKind::diff #7813

merged 1 commit into from
Oct 4, 2023

Conversation

charliermarsh
Copy link
Member

No description provided.

@charliermarsh charliermarsh added the internal An internal refactor or improvement label Oct 4, 2023
dhruvmanila
dhruvmanila approved these changes Oct 4, 2023
View reviewed changes
crates/ruff_linter/src/source_kind.rs Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023 •
edited
Loading

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

@charliermarsh charliermarsh force-pushed the charlie/source-kind branch 2 times, most recently from 775d98d to 17c879b Compare October 4, 2023 14:58
@charliermarsh charliermarsh enabled auto-merge (squash) October 4, 2023 14:59
@charliermarsh charliermarsh merged commit bb87f75 into main Oct 4, 2023
14 checks passed
@charliermarsh charliermarsh deleted the charlie/source-kind branch October 4, 2023 15:08
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 4, 2023

CodSpeed Performance Report

Merging #7813 will degrade performances by 3.38%

Comparing charlie/source-kind (fdd3b2b) with main (e674e87)

Summary

❌ 1 regressions
✅ 24 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main charlie/source-kind Change
❌ linter/default-rules[large/dataset.py] 92.8 ms 96 ms -3.38%

@bluthej bluthej mentioned this pull request Oct 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvmanila dhruvmanila dhruvmanila approved these changes

Assignees
No one assigned
Labels
internal An internal refactor or improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charliermarsh @dhruvmanila