Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect .python-version files and pyproject.toml in uv python find #6369

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

zanieb
Copy link
Member

@zanieb zanieb commented Aug 21, 2024

I was surprised to find we didn't do this — we should find Python versions as we do everywhere else.

@zanieb zanieb added the enhancement New feature or improvement to existing functionality label Aug 21, 2024
@zanieb zanieb force-pushed the zb/python-find-pin branch from ad7737a to 4733b14 Compare August 21, 2024 19:10
@zanieb zanieb added the cli Related to the command line interface label Aug 21, 2024
Base automatically changed from zb/version-file-refactor to main August 21, 2024 21:41
@zanieb zanieb force-pushed the zb/python-find-pin branch from 4733b14 to b82e2d8 Compare August 21, 2024 21:41
@zanieb zanieb force-pushed the zb/python-find-pin branch from b82e2d8 to c43d54f Compare August 21, 2024 21:53
@zanieb zanieb enabled auto-merge (squash) August 21, 2024 21:56
@zanieb zanieb force-pushed the zb/python-find-pin branch from c43d54f to 1e375ef Compare August 21, 2024 22:01
@zanieb zanieb merged commit 7140cde into main Aug 21, 2024
56 checks passed
@zanieb zanieb deleted the zb/python-find-pin branch August 21, 2024 22:08
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Aug 22, 2024
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [astral-sh/uv](https://github.com/astral-sh/uv) | patch | `0.3.0` -> `0.3.1` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>astral-sh/uv (astral-sh/uv)</summary>

### [`v0.3.1`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#031)

[Compare Source](astral-sh/uv@0.3.0...0.3.1)

##### Enhancements

-   Add `--with-editable` support to `uv run` ([#&#8203;6262](astral-sh/uv#6262))
-   Respect `.python-version` files and `pyproject.toml` in `uv python find` ([#&#8203;6369](astral-sh/uv#6369))
-   Allow manylinux compatibility override via `_manylinux` module ([#&#8203;6039](astral-sh/uv#6039))

##### CLI

-   Avoid treating `uv add -r` as `--raw-sources` ([#&#8203;6287](astral-sh/uv#6287))

##### Bug fixes

-   Always invoke found interpreter when `uv run python` is used ([#&#8203;6363](astral-sh/uv#6363))
-   Avoid adding extra newline for script with non-empty prelude ([#&#8203;6366](astral-sh/uv#6366))
-   Fix metadata cache instability for lockfile ([#&#8203;6332](astral-sh/uv#6332))
-   Handle Ctrl-C properly in `uvx` invocations ([#&#8203;6346](astral-sh/uv#6346))
-   Ignore workspace discovery errors with `--no-workspace` ([#&#8203;6328](astral-sh/uv#6328))
-   Invalidate `uv.lock` when virtual `dev-dependencies` change ([#&#8203;6291](astral-sh/uv#6291))
-   Make cache robust to removed archives ([#&#8203;6284](astral-sh/uv#6284))
-   Preserve Git username for SSH dependencies ([#&#8203;6335](astral-sh/uv#6335))
-   Respect `--no-build-isolation` in `uv add` ([#&#8203;6368](astral-sh/uv#6368))
-   Respect `.python-version` files in `uv run` outside projects ([#&#8203;6361](astral-sh/uv#6361))
-   Use `sys_executable` for `uv run` invocations ([#&#8203;6354](astral-sh/uv#6354))
-   Use atomic write for `pip compile` output ([#&#8203;6274](astral-sh/uv#6274))
-   Use consistent logic for deserializing short revisions ([#&#8203;6341](astral-sh/uv#6341))

##### Documentation

-   Remove the preview default value of `python-preference` ([#&#8203;6301](astral-sh/uv#6301))
-   Update env vars doc about `XDG_*` variables on macOS ([#&#8203;6337](astral-sh/uv#6337))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
zanieb added a commit that referenced this pull request Nov 4, 2024
…6370)

Uses #6369 for test coverage.

Updates version file discovery to search up into parent directories.
Also refactors Python request determination to avoid duplicating the
user request / version file / workspace lookup logic in every command
(this supersedes the work started in
#6372).

There is a bit of remaining work here, mostly around documentation.
There are some edge-cases where we don't use the refactored request
utility, like `uv build` — I'm not sure how I'm going to handle that yet
as it needs a separate root directory.
zanieb added a commit that referenced this pull request Nov 4, 2024
…6370)

Uses #6369 for test coverage.

Updates version file discovery to search up into parent directories.
Also refactors Python request determination to avoid duplicating the
user request / version file / workspace lookup logic in every command
(this supersedes the work started in
#6372).

There is a bit of remaining work here, mostly around documentation.
There are some edge-cases where we don't use the refactored request
utility, like `uv build` — I'm not sure how I'm going to handle that yet
as it needs a separate root directory.
zanieb added a commit that referenced this pull request Nov 5, 2024
…6370)

Uses #6369 for test coverage.

Updates version file discovery to search up into parent directories.
Also refactors Python request determination to avoid duplicating the
user request / version file / workspace lookup logic in every command
(this supersedes the work started in
#6372).

There is a bit of remaining work here, mostly around documentation.
There are some edge-cases where we don't use the refactored request
utility, like `uv build` — I'm not sure how I'm going to handle that yet
as it needs a separate root directory.
charliermarsh pushed a commit that referenced this pull request Nov 6, 2024
…6370)

Uses #6369 for test coverage.

Updates version file discovery to search up into parent directories.
Also refactors Python request determination to avoid duplicating the
user request / version file / workspace lookup logic in every command
(this supersedes the work started in
#6372).

There is a bit of remaining work here, mostly around documentation.
There are some edge-cases where we don't use the refactored request
utility, like `uv build` — I'm not sure how I'm going to handle that yet
as it needs a separate root directory.
charliermarsh pushed a commit that referenced this pull request Nov 6, 2024
…6370)

Uses #6369 for test coverage.

Updates version file discovery to search up into parent directories.
Also refactors Python request determination to avoid duplicating the
user request / version file / workspace lookup logic in every command
(this supersedes the work started in
#6372).

There is a bit of remaining work here, mostly around documentation.
There are some edge-cases where we don't use the refactored request
utility, like `uv build` — I'm not sure how I'm going to handle that yet
as it needs a separate root directory.
charliermarsh pushed a commit that referenced this pull request Nov 6, 2024
…6370)

Uses #6369 for test coverage.

Updates version file discovery to search up into parent directories.
Also refactors Python request determination to avoid duplicating the
user request / version file / workspace lookup logic in every command
(this supersedes the work started in
#6372).

There is a bit of remaining work here, mostly around documentation.
There are some edge-cases where we don't use the refactored request
utility, like `uv build` — I'm not sure how I'm going to handle that yet
as it needs a separate root directory.
zanieb added a commit that referenced this pull request Nov 7, 2024
…6370)

Uses #6369 for test coverage.

Updates version file discovery to search up into parent directories.
Also refactors Python request determination to avoid duplicating the
user request / version file / workspace lookup logic in every command
(this supersedes the work started in
#6372).

There is a bit of remaining work here, mostly around documentation.
There are some edge-cases where we don't use the refactored request
utility, like `uv build` — I'm not sure how I'm going to handle that yet
as it needs a separate root directory.
zanieb added a commit that referenced this pull request Nov 7, 2024
…6370)

Uses #6369 for test coverage.

Updates version file discovery to search up into parent directories.
Also refactors Python request determination to avoid duplicating the
user request / version file / workspace lookup logic in every command
(this supersedes the work started in
#6372).

There is a bit of remaining work here, mostly around documentation.
There are some edge-cases where we don't use the refactored request
utility, like `uv build` — I'm not sure how I'm going to handle that yet
as it needs a separate root directory.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Related to the command line interface enhancement New feature or improvement to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants