Improve interactions between .python-version files and project requires-python
#6372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
commented
Aug 21, 2024
zanieb
force-pushed
the
zb/version-file-discover
branch
from
916db9c to
df3693e
Compare
zanieb
force-pushed
the
zb/version-file-discover-project
branch
from
62dd871 to
5b48cf1
Compare
zanieb
force-pushed
the
zb/version-file-discover
branch
2 times, most recently
from
1e02b28 to
2ca5bb4
Compare
zanieb
force-pushed
the
zb/version-file-discover-project
branch
4 times, most recently
from
ff3d300 to
584401d
Compare
zanieb
force-pushed
the
zb/version-file-discover
branch
from
2ca5bb4 to
6f07881
Compare
|
With this PR a project with a I think it makes sense that |
Basically, yes. We will do our best to respect |
zanieb
force-pushed
the
zb/version-file-discover
branch
from
6f07881 to
3564e75
Compare
zanieb
force-pushed
the
zb/version-file-discover-project
branch
from
584401d to
fdde4bf
Compare
zanieb
force-pushed
the
zb/version-file-discover
branch
6 times, most recently
from
0c31b66 to
932048f
Compare
zanieb
added a commit
that referenced
this pull request
Nov 4, 2024
…6370) Uses #6369 for test coverage. Updates version file discovery to search up into parent directories. Also refactors Python request determination to avoid duplicating the user request / version file / workspace lookup logic in every command (this supersedes the work started in #6372). There is a bit of remaining work here, mostly around documentation. There are some edge-cases where we don't use the refactored request utility, like `uv build` — I'm not sure how I'm going to handle that yet as it needs a separate root directory.
zanieb
added a commit
that referenced
this pull request
Nov 4, 2024
…6370) Uses #6369 for test coverage. Updates version file discovery to search up into parent directories. Also refactors Python request determination to avoid duplicating the user request / version file / workspace lookup logic in every command (this supersedes the work started in #6372). There is a bit of remaining work here, mostly around documentation. There are some edge-cases where we don't use the refactored request utility, like `uv build` — I'm not sure how I'm going to handle that yet as it needs a separate root directory.
zanieb
added a commit
that referenced
this pull request
Nov 5, 2024
…6370) Uses #6369 for test coverage. Updates version file discovery to search up into parent directories. Also refactors Python request determination to avoid duplicating the user request / version file / workspace lookup logic in every command (this supersedes the work started in #6372). There is a bit of remaining work here, mostly around documentation. There are some edge-cases where we don't use the refactored request utility, like `uv build` — I'm not sure how I'm going to handle that yet as it needs a separate root directory.
charliermarsh
pushed a commit
that referenced
this pull request
Nov 6, 2024
…6370) Uses #6369 for test coverage. Updates version file discovery to search up into parent directories. Also refactors Python request determination to avoid duplicating the user request / version file / workspace lookup logic in every command (this supersedes the work started in #6372). There is a bit of remaining work here, mostly around documentation. There are some edge-cases where we don't use the refactored request utility, like `uv build` — I'm not sure how I'm going to handle that yet as it needs a separate root directory.
charliermarsh
pushed a commit
that referenced
this pull request
Nov 6, 2024
…6370) Uses #6369 for test coverage. Updates version file discovery to search up into parent directories. Also refactors Python request determination to avoid duplicating the user request / version file / workspace lookup logic in every command (this supersedes the work started in #6372). There is a bit of remaining work here, mostly around documentation. There are some edge-cases where we don't use the refactored request utility, like `uv build` — I'm not sure how I'm going to handle that yet as it needs a separate root directory.
charliermarsh
pushed a commit
that referenced
this pull request
Nov 6, 2024
…6370) Uses #6369 for test coverage. Updates version file discovery to search up into parent directories. Also refactors Python request determination to avoid duplicating the user request / version file / workspace lookup logic in every command (this supersedes the work started in #6372). There is a bit of remaining work here, mostly around documentation. There are some edge-cases where we don't use the refactored request utility, like `uv build` — I'm not sure how I'm going to handle that yet as it needs a separate root directory.
zanieb
added a commit
that referenced
this pull request
Nov 7, 2024
…6370) Uses #6369 for test coverage. Updates version file discovery to search up into parent directories. Also refactors Python request determination to avoid duplicating the user request / version file / workspace lookup logic in every command (this supersedes the work started in #6372). There is a bit of remaining work here, mostly around documentation. There are some edge-cases where we don't use the refactored request utility, like `uv build` — I'm not sure how I'm going to handle that yet as it needs a separate root directory.
zanieb
added a commit
that referenced
this pull request
Nov 7, 2024
…6370) Uses #6369 for test coverage. Updates version file discovery to search up into parent directories. Also refactors Python request determination to avoid duplicating the user request / version file / workspace lookup logic in every command (this supersedes the work started in #6372). There is a bit of remaining work here, mostly around documentation. There are some edge-cases where we don't use the refactored request utility, like `uv build` — I'm not sure how I'm going to handle that yet as it needs a separate root directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5228
Required for #6370
This ensures that we
.python-versionfiles outside of projects if they specify a version that's incompatible with therequires-python.python-versionfiles inside a project are incompatible with therequires-pythonUnfortunately, this totally falls apart if the
.python-versionfile isn't a version specifier, e.g., if it's an interpreter path.This begins to create a unified place to determine the
PythonRequestto use — it's getting really complicated.