Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Error in EBV initialization in ratios.flux_ratios #57

Closed
astrochun opened this issue Jun 14, 2020 · 0 comments · Fixed by #53
Closed

Bug: Error in EBV initialization in ratios.flux_ratios #57

astrochun opened this issue Jun 14, 2020 · 0 comments · Fixed by #53
Assignees
@astrochun
Labels
bug Something isn't working

Comments

@astrochun
Copy link
Owner

EBV is initialized using the shape of OIII4363; however, this is only defined if get_R == True. Thus, determining flux ratios using EBV won't work. Ultimately we should allow ratios.flux_ratios to provide dust-corrected flux ratios
@astrochun astrochun added the bug Something isn't working label Jun 14, 2020
@astrochun astrochun self-assigned this Jun 14, 2020
@astrochun astrochun linked a pull request Jun 14, 2020 that will close this issue
release/1.1.0 #53
Merged
astrochun added a commit that referenced this issue Jun 14, 2020
@astrochun
Fix bug with EBV initialization (iss #57)
ef082ca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@astrochun astrochun

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

release/1.1.0 astrochun/Metallicity_Stack_Commons
1 participant
@astrochun