Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release/1.1.0 #53

Merged
merged 61 commits into from
Jun 14, 2020
Merged

release/1.1.0 #53

merged 61 commits into from
Jun 14, 2020

Conversation

astrochun
Copy link
Owner

@astrochun astrochun commented May 30, 2020 •
edited
Loading

Includes iss #10 (feature/plotting_balmer) and #56

@astrochun
plotting.balmer: Fix variable name (bug): combine_ascii -> astropy ta…
ac9ae4a 
…ble (iss #10)
@astrochun
plotting.balmer.extract_fit: Strip astropy column to get numpy array …
4b51da9 
…(iss #10)
@astrochun
plotting.balmer: Import numpy (iss #10)
f4625a8
@astrochun
plotting.balmer.HbHgHd_fits: Define wave_beta, wave_gamma, wave_delta…
2b2d444 
… (iss #10)
@astrochun
plotting.balmer.extract_fit: PEP8 and update docstrings (iss #10)
761e7b7
@astrochun
plotting.balmer.HbHgHd_fits: Remove unused variables (iss #10)
46802b5
@astrochun
plotting.balmer.HbHgHd_fits: rename variables for readability (iss #10)
e242d07
@astrochun
plotting.balmer: Fix extra spaces, missing spaces, etc (iss #10)
62a3d4a
@astrochun
plotting.balmer.extract_fit: Use column_names definition #25 (iss #10)
c9e7dca
@astrochun
plotting.balmer.HbHgHd_fits: Fix line name, Hgamma -> HGAMMA (iss #10)
9f895f3
@astrochun
plotting.balmer.HbHgHd_fits: PEP compatibility (iss #10)
cf0fa2b
@astrochun
plotting.balmer.HbHgHd_fits: Remove dispersion definition -unused (iss …
8f2440d 
…#10)
@astrochun
plotting.balmer.fitting_result: Fix incorrect name (iss #10)
10f03ce
@astrochun
plotting.balmer.fitting_result: Switch to double-quote docstrings (iss …
028697d 
…#10)
@astrochun
plotting.balmer: Rename of arrays, PEP8 rules (iss #10)
5f87da0
@astrochun
plotting.balmer.fitting_result: Fix bug - define dx (iss #10)
faa9c65
@astrochun
plotting.balmer.HbHgHd_fits: Ignore unbound issue with definition wit…
8a769b3 
…hin if statement (iss #10)
@astrochun
plotting.balmer.HbHgHd_fits: Remove dx definition - not used (iss #10)
43577ac
@astrochun
plotting.balmer.extract_fit.fitting_result: Update docstrings (iss #10)
c87ecce
@astrochun
plotting.balmer.HbHgHd_fits: Change pdf_pages variable name for PEP8 …
2568966 
…(iss #10)
@astrochun
plotting.balmer.HbHgHd_fits: Update docstrings (iss #10)
362bb4d
@astrochun
attenuation: Update docstrings and PEP8 formatting (iss #10)
ab0d355
@astrochun
attenuation.compute_EBV: Use os.path.join (iss #10)
199acb8
@astrochun
attenuation.compute_A: Add docstrings (iss #10)
c92c293
@astrochun
attenuation.Hb_SFR: Define and use HaHb_CaseB; Switch to k_HBETA vari…
b74e2e8 
…able (iss #10)
@astrochun
plotting.balmer: Some notes on compatibility when merging into master…
c2e443f 
… (iss #10)
@astrochun
Address merge conflicts for PR #23
677472c
@astrochun
plotting.balmer: Remove extraneous comments (iss #10)
0942325
@astrochun
plotting.balmer.HbHgHd_fits: Proper call of fitting_result with *args…
542c646 
… (iss #10)
@astrochun
Use line_name_sort for HB and HG name conventions (iss #10)
cd02279
astrochun added 9 commits June 2, 2020 21:52
@astrochun
analysis.attenuation.compute_EBV: Allow for use_revised keyword optio…
3f13ccb 
…ns to specify different inputs (iss #10)
@astrochun
analysis.attenuation: Fix typo (iss #10)
7234f67
@astrochun
analysis.attenuation.compute_EBV: Check for derived properties file b…
2191654 
…efore adding dust attenuation information (iss #10)
@astrochun
analysis.attenuation.compute_EBV: Fix a few typos (iss #10)
7a39db4
@astrochun
analysis.attenuation.compute_EBV: Fix a typo in Column name (iss #10)
0cf7167
@astrochun
plotting.balmer.extract_fit: Fix memory caching for single entries fr…
d9238d5 
…om astropy tables (iss #10)
@astrochun
analysis.attenuation: Add Hd/Hb (iss #56)
8fb5f93
@astrochun
analysis.attenuation: Reorganize compute_EBV to EBV_table_update; Cre…
797fd52 
…ate new compute_EBV; Get Hg and Hd EBV estimates (iss #56)
@astrochun
analysis.attenuation: Reorganize compute_EBV to EBV_table_update; Cre…
92a4616 
…ate new compute_EBV; Get Hg and Hd EBV estimates (iss #56)
@astrochun astrochun linked an issue Jun 5, 2020 that may be closed by this pull request
EBV calculation for Hd/Hb #56
Closed
astrochun added 12 commits June 5, 2020 14:34
@astrochun
balmer.HbHgHd_fits: Plot aesthetics, include Balmer decrements in ann…
2165c50 
…otation (iss #10)
@astrochun
balmer.HbHgHd_fits: Plot aesthetics for white space (iss #10)
9d9097f
@astrochun
balmer.HbHgHd_fits: Compute EBV and annotate plots (iss #10)
7ed3945
@astrochun
balmer.HbHgHd_fits: Add fitspath input, fix out_pdf prefix, use colum…
5021fb7 
…n_names for filename convention (iss #10)
@astrochun
column_names: Add comp_spec file (iss #25)
f4a290e
@astrochun
balmer.HbHgHd_fits: Use comp_spec filename_dict definition (iss #10)
4dee557
@astrochun
balmer.HbHgHd_fits: Bug fix in annotation input (iss #10)
147bddf
@astrochun
balmer.HbHgHd_fits: Label axes (iss #10)
57605f1
@astrochun
balmer.HbHgHd_fits: Fix file path to provide absolute one (iss #10)
ce66e50
@astrochun
balmer.HbHgHd_fits: Plot aesthetics for less white space, tick labels…
2e20212 
… (iss #10)
@astrochun
balmer.HbHgHd_fits: Force ticks on the inside (iss #10)
29d30df
@astrochun
balmer.HbHgHd_fits: smaller wspace for subplots_adjust (iss #10)
0d11b1b
@astrochun astrochun linked an issue Jun 14, 2020 that may be closed by this pull request
Bug: Error in EBV initialization in ratios.flux_ratios #57
Closed
astrochun
astrochun commented Jun 14, 2020
View reviewed changes
Copy link
Owner Author

@astrochun astrochun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and tested for both Evolution-of-Galaxies and Zcalbase_gal

@astrochun astrochun merged commit 5da6271 into master Jun 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@astrochun astrochun

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@astrochun