Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-organize temp_metallicity_calc #6

Closed
astrochun opened this issue Jan 30, 2020 · 3 comments
Closed

Re-organize temp_metallicity_calc #6

astrochun opened this issue Jan 30, 2020 · 3 comments
Assignees
Labels
organization Simplify with imports, remove extraneous stuff

Comments

@astrochun
Copy link
Owner

astrochun commented Jan 30, 2020

Action items include:

  • Using k_dict
  • Documenting each function
  • Removing extraneous information
  • Combining metallicity info into a dictionary to make it easier to call (but this will not include com_O_log)
@astrochun
Copy link
Owner Author

astrochun commented Jan 30, 2020

Note: Issue is open as we are awaiting testing in Zcalbase_gal and Evolution-of-Galaxies

After that has been completed, we will merge feature/temp_metal into develop

Test in develop before merging in to master

@astrochun
Copy link
Owner Author

PR #7 completed with no conflicts (feature/temp_metal -> develop)

@astrochun astrochun self-assigned this Jan 31, 2020
@astrochun astrochun added the organization Simplify with imports, remove extraneous stuff label Feb 2, 2020
@astrochun
Copy link
Owner Author

Already merged into develop and ready for release/0.3.0. Closing issue now.

astrochun added a commit that referenced this issue Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
organization Simplify with imports, remove extraneous stuff
Projects
None yet
Development

No branches or pull requests

1 participant