Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a separate module for error propagation #5

Closed
10 tasks done
astrochun opened this issue Jan 19, 2020 · 6 comments
Closed
10 tasks done

Create a separate module for error propagation #5

astrochun opened this issue Jan 19, 2020 · 6 comments
Assignees
Labels

Comments

@astrochun
Copy link
Owner

astrochun commented Jan 19, 2020

The module would be called error_prop

It will include:

  1. Construction of probability distribution functions (PDFs) based on inputs and 1-sigma uncertainties
  2. Calculation of 68-percentile uncertainties given a PDF and initial guess.
  3. A ratios package that computes different emission-line ratios. This is something that will work with simple emission-line ratios and PDFs of those ratios.
  4. Derive properties (T_e, metallicity) from flux ratio PDFs
  5. Write npz files, such as that done in Zcalbase_gal
  6. Define npz files in column_names module
  7. Change metallicity_calculation to return a single dictionary instead of splitting content out
  8. Write PDFs for derived properties
  9. Write revised derived properties table
  10. Set numpy random seeds
@astrochun
Copy link
Owner Author

We might want to make construct_pdf() to handle multiple sets. Perhaps use a dictionary approach?

@astrochun
Copy link
Owner Author

During group discussion, an idea that I came up with is a function that would generate the flux ratios and derived properties regardless of individual measurements or distribution function.

astrochun added a commit that referenced this issue Mar 9, 2020
astrochun added a commit that referenced this issue Mar 15, 2020
astrochun added a commit that referenced this issue Mar 27, 2020
astrochun added a commit that referenced this issue Mar 27, 2020
…ies in clean fashion with for loop; renaming clean-up (iss #5)
astrochun added a commit that referenced this issue Mar 27, 2020
astrochun added a commit that referenced this issue Mar 27, 2020
astrochun added a commit that referenced this issue Mar 27, 2020
… -> Te_pdf, metal_peak -> derived_prop_peak, metal_error -> derived_prop_error (iss #5)
astrochun added a commit that referenced this issue Mar 28, 2020
astrochun added a commit that referenced this issue Mar 28, 2020
astrochun added a commit that referenced this issue Mar 28, 2020
@astrochun
Copy link
Owner Author

astrochun commented Mar 28, 2020

Note: composite_indv_detect will need to be updated for metallicity_calculation() return information. This can be done within release/0.6.0. This way, I would not need to merge in composite_indv_detect

@astrochun
Copy link
Owner Author

Code works for Caroline's example dataset that was provided. For Reagen, she had to switch to Python 3, but that was due to a dependency fix in column_names module that was not incorporated within feature/error_prop. After the merge of PR #24 and resolving conflicts, we should be good.

astrochun added a commit that referenced this issue Mar 29, 2020
@astrochun astrochun mentioned this issue Mar 29, 2020
astrochun added a commit that referenced this issue Mar 29, 2020
@astrochun
Copy link
Owner Author

Issue is now resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant