-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CODEOWNERS to track all files #276
Conversation
The first argument in the CODEOWNERS file tells what all files to monitor for changes. Since, we din't specify any file, the code review requests are not getting sent. Specifying the wild card asterisk tells it to monitor for all files in the repo & accordingly work for the CODEOWNERS features such as sending review requests to the CODEOWNERS upon opening pull requests.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #276 +/- ##
=======================================
Coverage 93.96% 93.96%
=======================================
Files 8 8
Lines 630 630
=======================================
Hits 592 592
Misses 38 38 ☔ View full report in Codecov by Sentry. |
@@ -1 +1 @@ | |||
@oss-integrations | |||
* @astronomer/oss-integrations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this, @pankajkoti ! I hadn't realised before we were missing the org.
### Added - Add support to TaskFlow and improve dynamic task mapping support by @tatiana in #314 - Render YML DAG config as DAG Docs by @pankajastro #305 - Support building DAGs out of topologically unsorted YAML files by @tatiana in #307 - Add support for nested task groups by @glazunov996 and @pankajastro in #292 - Add support for templating `on_failure_callback` by @jroach-astronomer #252 ### Fixed - Fix compatibility with apache-airflow-providers-cncf-kubernetes>=10.0.0 by @tatiana in #311 - Refactor telemetry to collect events during DAG run and not during DAG parsing by @pankajastro #300 ### Docs - Fix reference for HttpSensor in README.md by @pankajastro in #277 - Add example DAG for task group by @pankajastro in #293 - Add CODEOWNERS by @pankajkoti in #270 - Update CODEOWNERS to track all files by @pankajkoti in #276 - Modified Status badge in README by @jaejun #298 ### Others - Refactor dynamic task mapping implementation by @tatiana in #313 - Remove pytest durations from tests by @tatiana in #309 - Remove DAG retries check since many DAGs have different retry values by @tatiana in #310 - Lint fixes after running `pre-commit run --all-files` by @tatiana in #312 - Remove redundant exception code by @pankajastro #294 - Add GitHub issue template for bug reports and feature requests by @pankajkoti in #269 Closes: #223
The first argument in the CODEOWNERS file tells what all files to monitor for changes. Since, we din't specify any file, the code review requests are not getting sent. Specifying the wild card asterisk tells it to monitor for all files in the repo & accordingly work for the CODEOWNERS features such as sending review requests to the CODEOWNERS upon opening pull requests.