Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CODEOWNERS to track all files #276

Merged
merged 2 commits into from
Oct 28, 2024
Merged

Update CODEOWNERS to track all files #276

merged 2 commits into from
Oct 28, 2024

Conversation

pankajkoti
Copy link
Contributor

The first argument in the CODEOWNERS file tells what all files to monitor for changes. Since, we din't specify any file, the code review requests are not getting sent. Specifying the wild card asterisk tells it to monitor for all files in the repo & accordingly work for the CODEOWNERS features such as sending review requests to the CODEOWNERS upon opening pull requests.

The first argument in the CODEOWNERS file tells what all files to monitor for changes. Since, we din't specify any file, the code review requests are not getting sent. Specifying the wild card asterisk tells it to monitor for all files in the repo & accordingly work for the CODEOWNERS features such as sending review requests to the CODEOWNERS upon opening pull requests.
@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.96%. Comparing base (644ad62) to head (fe2626a).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #276   +/-   ##
=======================================
  Coverage   93.96%   93.96%           
=======================================
  Files           8        8           
  Lines         630      630           
=======================================
  Hits          592      592           
  Misses         38       38           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tatiana tatiana merged commit 1c999f5 into main Oct 28, 2024
67 checks passed
@tatiana tatiana deleted the pankajkoti-patch-1 branch October 28, 2024 10:45
@@ -1 +1 @@
@oss-integrations
* @astronomer/oss-integrations
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this, @pankajkoti ! I hadn't realised before we were missing the org.

@tatiana tatiana mentioned this pull request Dec 6, 2024
tatiana added a commit that referenced this pull request Dec 6, 2024
### Added

- Add support to TaskFlow and improve dynamic task mapping support by
@tatiana in #314
- Render YML DAG config as DAG Docs by @pankajastro #305
- Support building DAGs out of topologically unsorted YAML files by
@tatiana in #307
- Add support for nested task groups by @glazunov996 and @pankajastro in
#292
- Add support for templating `on_failure_callback` by @jroach-astronomer
#252

### Fixed

- Fix compatibility with
apache-airflow-providers-cncf-kubernetes>=10.0.0 by @tatiana in #311
- Refactor telemetry to collect events during DAG run and not during DAG
parsing by @pankajastro #300

### Docs

- Fix reference for HttpSensor in README.md by @pankajastro in #277
- Add example DAG for task group by @pankajastro in #293
- Add CODEOWNERS by @pankajkoti in #270
- Update CODEOWNERS to track all files by @pankajkoti in #276
- Modified Status badge in README by @jaejun #298

### Others

- Refactor dynamic task mapping implementation by @tatiana in #313
- Remove pytest durations from tests by @tatiana in #309
- Remove DAG retries check since many DAGs have different retry values
by @tatiana in #310
- Lint fixes after running `pre-commit run --all-files` by @tatiana in
#312
- Remove redundant exception code by @pankajastro #294
- Add GitHub issue template for bug reports and feature requests by
@pankajkoti in #269

Closes: #223
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants