Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

velocity_marked_npairs_3d and velocity_marked_npairs_xy_z for default arguments #836

Closed
aphearin opened this issue Nov 28, 2017 · 0 comments
Closed

velocity_marked_npairs_3d and velocity_marked_npairs_xy_z for default arguments #836

aphearin opened this issue Nov 28, 2017 · 0 comments
Assignees
@duncandc
Labels
bug mock-observables
Milestone
v0.6

Comments

@aphearin
Copy link
Contributor

These functions currently fail when called with the default arguments.
@aphearin aphearin added this to the v0.6 milestone Nov 28, 2017
aphearin pushed a commit to aphearin/halotools that referenced this issue Nov 28, 2017
Added doctest to velocity_marked_npairs_3d and velocity_marked_npairs…
ee85b89 
…_xy_z functions. Up until now, these functions were not executed by any unit-test. The newly added doctest revealed a bug in both functions related to weight_func_id=0 not being recognized.

Additionally, the docstrings of both functions mention that further information about weight_func_id can be found in the Notes section, but there is no Notes section.

@duncandc - can you address this to resolve Issue astropy#836?
@duncandc duncandc mentioned this issue Dec 12, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@duncandc duncandc

Labels
bug mock-observables
Projects
None yet
Milestone
v0.6
Development

No branches or pull requests
2 participants
@duncandc @aphearin