bug fix in velocity_marked_npairs functions #859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_xy_z functions. Up until now, these functions were not executed by any unit-test. The newly added doctest revealed a bug in both functions related to weight_func_id=0 not being recognized. Additionally, the docstrings of both functions mention that further information about weight_func_id can be found in the Notes section, but there is no Notes section. @duncandc - can you address this to resolve Issue astropy#836?
aphearin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses issue #836.
There is no weight_func_id=0 for these velocity weighted functions. In addition, each function was being called incorrectly within the doc string example section.
I have corrected these bugs and modified the
weight_func_idnumbers of each weighting function to be more reasonable, e.g. 1,2,3,4. This change required updatingweight_func_idin a couple other locations with thepairwise_velocities module. These changes have been noted CHANGES.rst