Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using system pytest rather than astropy bundled #760

Closed
wants to merge 3 commits into from

Conversation

bsipocz
Copy link
Member

@bsipocz bsipocz commented Jun 3, 2017

The bundled version going to be deprecated in v2.0

@aphearin
Copy link
Contributor

aphearin commented Jun 3, 2017

Thanks for handling this @bsipocz - I put that hacky test in there because I kept forgetting to use the bundled version.

What led to pytest being re-adopted? In case explanation is long, can you point me to where I can read about the issue?

@bsipocz
Copy link
Member Author

bsipocz commented Jun 3, 2017

The key issue was that pytest 3+ doesn't support the one file bundling any more. Longish back and forth discussions are here:

astropy/astropy#5509
astropy/astropy#5694

@bsipocz bsipocz force-pushed the pytest_not_from_astropy branch from ba1c4b6 to d021d8b Compare June 4, 2017 14:48
@aphearin aphearin mentioned this pull request Jul 9, 2017
@bsipocz bsipocz closed this Jul 9, 2017
@@ -1,36 +0,0 @@
"""
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aphearin - you need to remove this file in #789, too

@bsipocz bsipocz deleted the pytest_not_from_astropy branch November 28, 2024 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants