Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use system pytest #789

Merged
merged 2 commits into from
Jul 10, 2017
Merged

Use system pytest #789

merged 2 commits into from
Jul 10, 2017

Conversation

aphearin
Copy link
Contributor

@aphearin aphearin commented Jul 9, 2017

Now that #788 has been merged so that astropy-helpers has been updated to 2.0, start using pytest instead of astropy bundled version.

@aphearin aphearin added this to the v0.6 milestone Jul 9, 2017
@aphearin aphearin self-assigned this Jul 9, 2017
@aphearin
Copy link
Contributor Author

aphearin commented Jul 9, 2017

@bsipocz and/or @astrofrog - now that I have updated to astropy-helpers v2.0 with #788, I am getting new UserWarnings that trigger test failures (possibly because I am using enable_deprecations_as_exceptions, although this could be a red herring). Although I am not sure why the warnings show up now but not before, this is perfectly fine, but the problem I have now is that I need to catch these warnings so that my tests do not fail. Can either of you suggest how I can accomplish this?

Note to @bsipocz - this PR replaces your previous #760, simply because I found it easier to just run a new recursive search-and-replace as opposed to rebasing.

@bsipocz
Copy link
Member

bsipocz commented Jul 9, 2017

@aphearin - The warnings show up now as pytest 3.1 changed the warnings policy, and now included in its core the previous pytest-warnings package. You can turn off the warnings with adding
addopts = -p no:warnings to the [pytest] session in setup.cfg

@aphearin
Copy link
Contributor Author

Gaw, sorry about that @bsipocz - I should have caught that one myself; obviously I was just thrown off by the sudden appearance of the harmless warnings (which I think I will keep after all, as some of them point to testing functions that could be improved).

@aphearin aphearin merged commit 723d2cc into astropy:master Jul 10, 2017
@aphearin aphearin deleted the import_pytest branch July 10, 2017 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants