Enable all BUT fieldalignment govet analyzer #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atc0005
force-pushed
the
i611-enable-additional-govet-analyzers
branch
from
ed09a48 to
2d00c0f
Compare
Retain same overall behavior, but explicitly disable the `fieldalignment` analyzer for now until we are able to retain the "struct size" diagnostic, but drop the "pointer bytes" diagnostic. refs GH-611
The `fieldanalyzer` linter does not yet offer a way (afaik) to disable the "pointer bytes" diagnostic, so we're still relying on the deprecated `maligned` linter for struct field size ordering. We enable all other analzers which are not otherwise explicitly excluded. refs GH-611
atc0005
force-pushed
the
i611-enable-additional-govet-analyzers
branch
from
2d00c0f to
7e5ed2e
Compare
|
Ignoring linting errors (they're expected) triggered by linter config changes introduced by this PR. Will fix them in a follow-up PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
fieldanalyzerlinter does not yet offer a way (afaik) to disable the "pointer bytes" diagnostic, so we're still relying on the deprecatedmalignedlinter for struct field size ordering.We enable all other analyzers which are not otherwise explicitly excluded.
fixes GH-611