Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable additional govet linter analyzers #611

Closed
atc0005 opened this issue Jan 26, 2022 · 0 comments · Fixed by #612
Closed

Enable additional govet linter analyzers #611

atc0005 opened this issue Jan 26, 2022 · 0 comments · Fixed by #612
Assignees
@atc0005
Labels
config enhancement New feature or request linting
Milestone
v0.29.1

Comments

@atc0005
Copy link
Owner

atc0005 commented Jan 26, 2022

Cross-post from atc0005/go-ci#482:

While testing whether atc0005/go-ci#302 is still unresolved, I temporarily enabled all analyzers for the govet linter and caught some legitimate issues for these analyzers:

  • nilness
  • shadow

It may be worth enabling all analyzers for this linter, but explicitly disabling the fieldalignment analyzer until atc0005/go-ci#302 is worked out.
@atc0005 atc0005 added enhancement New feature or request config linting labels Jan 26, 2022
@atc0005 atc0005 added this to the Next Maintenance Release milestone Jan 26, 2022
@atc0005 atc0005 self-assigned this Jan 26, 2022
atc0005 added a commit that referenced this issue Jan 26, 2022
@atc0005
Reorder golangci-lint settings (NOOP)
22313ec 
Retain same overall behavior, but explicitly disable the
`fieldalignment` analyzer for now until we are able to
retain the "struct size" diagnostic, but drop the "pointer bytes"
diagnostic.

refs GH-611
atc0005 added a commit that referenced this issue Jan 26, 2022
@atc0005
Enable all BUT fieldalignment govet analyzer
ed09a48 
The fieldanalyzer does not yet offer a way (afaik) to disable
the "pointer bytes" diagnostic, so we're still relying on the
deprecated maligned linter for struct field size ordering.

We enable all other anaylzers which are not otherwise explicitly
excluded.

refs GH-611
@atc0005 atc0005 mentioned this issue Jan 26, 2022
Merged
atc0005 added a commit that referenced this issue Jan 26, 2022
@atc0005
Enable all BUT fieldalignment govet analyzer
2d00c0f 
The `fieldanalyzer` linter does not yet offer a way (afaik) to
disable the "pointer bytes" diagnostic, so we're still relying on
the deprecated `maligned` linter for struct field size ordering.

We enable all other analzers which are not otherwise explicitly
excluded.

refs GH-611
atc0005 added a commit that referenced this issue Jan 26, 2022
@atc0005
Reorder golangci-lint settings (NOOP)
b739e55 
Retain same overall behavior, but explicitly disable the
`fieldalignment` analyzer for now until we are able to
retain the "struct size" diagnostic, but drop the "pointer bytes"
diagnostic.

refs GH-611
atc0005 added a commit that referenced this issue Jan 26, 2022
@atc0005
Enable all BUT fieldalignment govet analyzer
7e5ed2e 
The `fieldanalyzer` linter does not yet offer a way (afaik) to
disable the "pointer bytes" diagnostic, so we're still relying on
the deprecated `maligned` linter for struct field size ordering.

We enable all other analzers which are not otherwise explicitly
excluded.

refs GH-611
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atc0005 atc0005

Labels
config enhancement New feature or request linting
Projects
None yet
Milestone
v0.29.1
Development

Successfully merging a pull request may close this issue.

Enable all BUT fieldalignment govet analyzer atc0005/check-vmware
1 participant
@atc0005