Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

golangci-lint | Enable additional govet linter analyzers #482

Closed
atc0005 opened this issue Jan 26, 2022 · 0 comments · Fixed by #485
Closed

golangci-lint | Enable additional govet linter analyzers #482

atc0005 opened this issue Jan 26, 2022 · 0 comments · Fixed by #485
Assignees
@atc0005
Labels
enhancement New feature or request linting unstable
Milestone
v0.4.0

Comments

@atc0005
Copy link
Owner

atc0005 commented Jan 26, 2022

While testing whether #302 is still unresolved, I temporarily enabled all analyzers for the govet linter and caught some legitimate issues for these analyzers:

  • nilness
  • shadow

It may be worth enabling all analyzers for this linter, but explicitly disabling the fieldalignment analyzer until #302 is worked out.
@atc0005 atc0005 added enhancement New feature or request linting labels Jan 26, 2022
@atc0005 atc0005 added this to the Next Release milestone Jan 26, 2022
@atc0005 atc0005 self-assigned this Jan 26, 2022
@atc0005 atc0005 mentioned this issue Jan 26, 2022
Closed
@atc0005 atc0005 changed the title Enable additional govet linter analyzers golangci-lint | Enable additional govet linter analyzers Jan 27, 2022
atc0005 added a commit that referenced this issue Jan 27, 2022
@atc0005
Enable additional govet analyzers
e380d29 
- explicitly disable `fieldalignment` analyzer
- enable all other `govet` analyzers
  - this also pulls in `nilness` and `shadow`, both of which
    has proven useful (brief testing)

refs GH-482
@atc0005 atc0005 mentioned this issue Jan 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atc0005 atc0005

Labels
enhancement New feature or request linting unstable
Projects
None yet
Milestone
v0.4.0
Development

Successfully merging a pull request may close this issue.

Enable additional govet analyzers atc0005/go-ci
1 participant
@atc0005