perf(webapi): Increase maxWorkers limit to 10000 (flyteorg#5326)

Signed-off-by: Kevin Su <[email protected]>
austin362667 · May 7, 2024 · 3037925 · 3037925
1 parent cc8a9cc
commit 3037925
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/flyteplugins/go/tasks/pluginmachinery/internal/webapi/core.go b/flyteplugins/go/tasks/pluginmachinery/internal/webapi/core.go
@@ -21,7 +21,7 @@ const (
 	minCacheSize       = 10
 	maxCacheSize       = 500000
 	minWorkers         = 1
-	maxWorkers         = 100
+	maxWorkers         = 10000
 	minSyncDuration    = 5 * time.Second
 	maxSyncDuration    = time.Hour
 	minBurst           = 5

diff --git a/flyteplugins/go/tasks/pluginmachinery/internal/webapi/core_test.go b/flyteplugins/go/tasks/pluginmachinery/internal/webapi/core_test.go
@@ -52,7 +52,7 @@ func Test_validateConfig(t *testing.T) {
 
 		err := validateConfig(cfg)
 		assert.Error(t, err)
-		assert.Equal(t, "\ncache size is expected to be between 10 and 500000. Provided value is 0\nworkers count is expected to be between 1 and 100. Provided value is 0\nresync interval is expected to be between 5 and 3600. Provided value is 0\nread burst is expected to be between 5 and 10000. Provided value is 0\nread qps is expected to be between 1 and 100000. Provided value is 0\nwrite burst is expected to be between 5 and 10000. Provided value is 0\nwrite qps is expected to be between 1 and 100000. Provided value is 0", err.Error())
+		assert.Equal(t, "\ncache size is expected to be between 10 and 500000. Provided value is 0\nworkers count is expected to be between 1 and 10000. Provided value is 0\nresync interval is expected to be between 5 and 3600. Provided value is 0\nread burst is expected to be between 5 and 10000. Provided value is 0\nread qps is expected to be between 1 and 100000. Provided value is 0\nwrite burst is expected to be between 5 and 10000. Provided value is 0\nwrite qps is expected to be between 1 and 100000. Provided value is 0", err.Error())
 	})
 
 	t.Run("Above max", func(t *testing.T) {
@@ -74,7 +74,7 @@ func Test_validateConfig(t *testing.T) {
 
 		err := validateConfig(cfg)
 		assert.Error(t, err)
-		assert.Equal(t, "\ncache size is expected to be between 10 and 500000. Provided value is 1000000000\nworkers count is expected to be between 1 and 100. Provided value is 1000000000\nresync interval is expected to be between 5 and 3600. Provided value is 3.6e+07\nread burst is expected to be between 5 and 10000. Provided value is 1000000\nwrite burst is expected to be between 5 and 10000. Provided value is 1000000", err.Error())
+		assert.Equal(t, "\ncache size is expected to be between 10 and 500000. Provided value is 1000000000\nworkers count is expected to be between 1 and 10000. Provided value is 1000000000\nresync interval is expected to be between 5 and 3600. Provided value is 3.6e+07\nread burst is expected to be between 5 and 10000. Provided value is 1000000\nwrite burst is expected to be between 5 and 10000. Provided value is 1000000", err.Error())
 	})
 }