Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(webapi): Increase maxWorkers limit to 10000 #5326

Merged
merged 2 commits into from
May 6, 2024
Merged

Conversation

pingsutw
Copy link
Member

@pingsutw pingsutw commented May 5, 2024

Tracking issue

NA

What changes were proposed in this pull request?

Increase maxWorkers limit to 10000 to run more agent tasks in parallel.

How was this patch tested?

Remote cluster

Setup process

from flytekit import workflow, task, LaunchPlan
from flytekitplugins.dummy_agent import Sleep


@task(task_config=Sleep(duration=0.5))
def sleep_task() -> str:
    return "Hello World!"


@workflow()
def sleep_wf():
    for i in range(100):
        sleep_task()


@workflow
def load_test_wf():
    sleep_lp = LaunchPlan.get_or_create(
        name="fixed_inputs", workflow=sleep_wf, max_parallelism=100
    )
    for i in range(50):
        sleep_lp()

Screenshots

image

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

NA

Docs link

NA

Copy link

codecov bot commented May 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.08%. Comparing base (0a1c82c) to head (7e14b69).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5326      +/-   ##
==========================================
+ Coverage   61.07%   61.08%   +0.01%     
==========================================
  Files         794      794              
  Lines       51203    51203              
==========================================
+ Hits        31271    31277       +6     
+ Misses      17049    17043       -6     
  Partials     2883     2883              
Flag Coverage Δ
unittests-datacatalog 69.31% <ø> (ø)
unittests-flyteadmin 58.82% <ø> (+0.04%) ⬆️
unittests-flytecopilot 17.79% <ø> (ø)
unittests-flytectl 68.30% <ø> (ø)
unittests-flyteidl 79.30% <ø> (ø)
unittests-flyteplugins 61.94% <ø> (ø)
unittests-flytepropeller 57.32% <ø> (ø)
unittests-flytestdlib 65.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Kevin Su <[email protected]>
Copy link
Contributor

@kumare3 kumare3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the impact on memory

@pingsutw
Copy link
Member Author

pingsutw commented May 6, 2024

Memory usage increases by ~4% (325MB). Propeller has 8G memory.

Screenshot 2024-05-06 at 11 16 02 AM

@pingsutw pingsutw merged commit ccf9473 into master May 6, 2024
51 checks passed
@pingsutw pingsutw deleted the increse-workers branch May 6, 2024 06:03
@Future-Outlier
Copy link
Member

Memory usage increases by ~4% (325MB). Propeller has 8G memory.

Screenshot 2024-05-06 at 11 16 02 AM

Love it

austin362667 pushed a commit to austin362667/flyte that referenced this pull request May 7, 2024
robert-ulbrich-mercedes-benz pushed a commit to robert-ulbrich-mercedes-benz/flyte that referenced this pull request Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants