Fix small bug in rendering table (flyteorg#14)

- Missing entities are rendered as nil, instead of empty
austin362667 · May 7, 2024 · ff326ef · ff326ef
1 parent a244bc7
commit ff326ef
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/flytectl/printer/printer.go b/flytectl/printer/printer.go
@@ -50,7 +50,7 @@ func extractRow(data interface{}, columns []Column) []string {
 
 	for _, c := range columns {
 		out, err := jsonpath.Read(data, c.JSONPath)
-		if err != nil {
+		if err != nil || out == nil {
 			out = ""
 		}
 		tableData = append(tableData, fmt.Sprintf("%s", out))

diff --git a/flytectl/printer/printer_test.go b/flytectl/printer/printer_test.go
@@ -13,6 +13,7 @@ type Inner struct {
 	Y *time.Time `json:"y"`
 }
 
+// TODO Convert this to a Testable Example. For some reason the comparison fails
 func TestJSONToTable(t *testing.T) {
 	d := time.Date(2020, 1, 1, 0, 0, 0, 0, time.UTC)
 	j := []struct {
@@ -34,7 +35,7 @@ func TestJSONToTable(t *testing.T) {
 	// Output:
 	// | A     | S                    |
 	// ------- ----------------------
-	// | hello | %!s(<nil>)           |
+	// | hello |                      |
 	// | hello | 2020-01-01T00:00:00Z |
 	// | hello |                      |
 	// 3 rows