Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mobile styles using different heights #1539

Merged
merged 8 commits into from
Nov 9, 2018
Merged

Fix mobile styles using different heights #1539

merged 8 commits into from
Nov 9, 2018

Conversation

luisrudge
Copy link
Contributor

fix #1474

Changes

Before:
image

After:
image

References

#1474
#824
#1223

Testing

  • Visual testing

@luisrudge
Copy link
Contributor Author

Android:

image

image

@luisrudge
Copy link
Contributor Author

Small Icons:

image

@luisrudge
Copy link
Contributor Author

Loading indicator:
loading

@vctrfrnndz
Copy link
Contributor

LGTM 🤙

cocojoe
cocojoe approved these changes Nov 8, 2018
View reviewed changes
Copy link
Member

@cocojoe cocojoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't really review the CSS. However, based on the images 👍

@luisrudge luisrudge merged commit 7f8ed78 into master Nov 9, 2018
@luisrudge luisrudge deleted the fix/style-mobile branch November 9, 2018 13:24
@luisrudge luisrudge added this to the v11.12.0 milestone Nov 9, 2018
@luisrudge luisrudge mentioned this pull request Nov 12, 2018
Merged
1 task
luisrudge added a commit that referenced this pull request Nov 13, 2018
@luisrudge
Revert "Fix mobile styles using different heights (#1539)"
391e2a1 
This reverts commit 7f8ed78.
@luisrudge luisrudge mentioned this pull request Nov 14, 2018
Merged
luisrudge added a commit that referenced this pull request Nov 15, 2018
@luisrudge
Fix IE flexbox bugs (#1552)
93e4a04 
### Changes

This PR fixes

- Inconsistent padding across screens after #1547 
![image](https://user-images.githubusercontent.com/941075/48504661-7f7e7880-e82c-11e8-8ec9-5c5292ae1f0b.png)

- IE glitches after we added flexbox in #1539 (the actual issues were: https://github.com/philipwalton/flexbugs#flexbug-3, https://github.com/philipwalton/flexbugs#flexbug-4 and https://github.com/philipwalton/flexbugs#flexbug-6)
![image](https://user-images.githubusercontent.com/941075/48504602-65dd3100-e82c-11e8-9cf0-69980328ebc2.png)

# GIFs (it's not JIF)

## IE 10
![ie10](https://user-images.githubusercontent.com/941075/48504817-cf5d3f80-e82c-11e8-9794-5608a8a5a3ca.gif)

## IE 11
![ie11](https://user-images.githubusercontent.com/941075/48504894-fa479380-e82c-11e8-952a-0344370a433e.gif)

## Edge 17
![edge17](https://user-images.githubusercontent.com/941075/48505076-5b6f6700-e82d-11e8-86be-969287b1cd06.gif)


## Firefox
![firefox](https://user-images.githubusercontent.com/941075/48505083-5f9b8480-e82d-11e8-900c-3ba69e6e2e12.gif)

## Safari
![safari](https://user-images.githubusercontent.com/941075/48505320-ee100600-e82d-11e8-9de2-427ea14b56fd.gif)


## Chrome
![chrome](https://user-images.githubusercontent.com/941075/48505322-ef413300-e82d-11e8-80c5-5acd333c17d6.gif)


## Pixel 2
![pixel2](https://user-images.githubusercontent.com/941075/48505549-7393b600-e82e-11e8-8f30-0081aa36119c.gif)

## Galaxy S9

![galaxys9](https://user-images.githubusercontent.com/941075/48505555-77273d00-e82e-11e8-8406-ec573bb5df88.gif)


## iPhone 7
![iphone7](https://user-images.githubusercontent.com/941075/48505730-e9981d00-e82e-11e8-9dfe-963b526ead83.gif)


## iPhone X
![iphonex](https://user-images.githubusercontent.com/941075/48505736-ebfa7700-e82e-11e8-85c4-bb6fd75fbc04.gif)
@coperator coperator mentioned this pull request Mar 13, 2019
Closed
@MarcMagdi MarcMagdi mentioned this pull request Jan 20, 2020
Closed
@fernandomunizz89
Copy link

I still experiencing this on Samsung and iPhone devices.

Can anyone help me with this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cocojoe cocojoe cocojoe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v11.12.0
Development

Successfully merging this pull request may close these issues.

Too much white space pushes the Submit button down offscreen
4 participants
@luisrudge @vctrfrnndz @fernandomunizz89 @cocojoe