Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

too_many_requests: Error Copy #1649

Closed

Conversation

dm03514
Copy link
Contributor

@dm03514 dm03514 commented May 9, 2019

Changes

Please describe both what is changing and why this is important. Include:

  • Added copy to the english login errors to handle the case of too_many_requests
  • Added a montebank configuration file used to generate the 429 error for /usernamepassword/login flow
  • This should show a custom error message when a user encounters too many requests from the server.

Screen Shot 2019-05-09 at 3 48 14 PM

References

Please include relevant links supporting this change such as a:

  • support ticket
  • community post
  • StackOverflow post
  • support forum thread

Please note any links that are not publicly accessible.

Testing

Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

  • This change adds unit test coverage
  • This change adds integration test coverage
  • This change has been tested on the latest version of the platform/language

Checklist

Copy link
Contributor

@luisrudge luisrudge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please remove the test/montebank/imposters.json file?

@dm03514 dm03514 requested a review from a team May 22, 2019 12:07
Removes mountebank test file
@dm03514 dm03514 force-pushed the feature/MONKEY-46/too-many-requests-copy branch from 6e88b95 to a442903 Compare May 22, 2019 12:07
@dm03514
Copy link
Contributor Author

dm03514 commented May 22, 2019

@luisrudge Updated (sorry didn't see until this morning)

@luisrudge
Copy link
Contributor

not sure what I did, but I had to create another PR #1655

@luisrudge luisrudge closed this May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants