Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error message for too_many_requests #1655

Merged
merged 4 commits into from
May 24, 2019
Merged

Add error message for too_many_requests #1655

merged 4 commits into from
May 24, 2019

Conversation

luisrudge
Copy link
Contributor

@luisrudge luisrudge commented May 24, 2019

same as #1649

Changes

Please describe both what is changing and why this is important. Include:

  • Added error messages for too_many_requests

@luisrudge luisrudge requested a review from a team May 24, 2019 18:39
@luisrudge luisrudge changed the title Pr/dm03514/1649 Add error message for too_many_requests May 24, 2019
@luisrudge luisrudge mentioned this pull request May 24, 2019
9 tasks
@@ -36,6 +36,7 @@ const processNode = async (enNode, langNode, lang) => {
await processNode(enNode[enKey], langNode[enKey], lang);
} else {
if (!langNode[enKey]) {
console.log('translating ', enKey);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup. to know what keys I'm translating.

"לא ניתן להשלים את ניסיון ההזדהות. אנא נסה שנית לאחר סגירת כל החלונות הפתוחים.",
'hrd.not_matching_email': 'על מנת להיכנס, אנא השתמש בחשבון המייל הארגוני שלך'
'לא ניתן להשלים את ניסיון ההזדהות. אנא נסה שנית לאחר סגירת כל החלונות הפתוחים.',
'hrd.not_matching_email': 'על מנת להיכנס, אנא השתמש בחשבון המייל הארגוני שלך',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah! good one

@luisrudge luisrudge merged commit 5d2fbc6 into master May 24, 2019
@luisrudge luisrudge deleted the pr/dm03514/1649 branch May 24, 2019 19:16
@luisrudge luisrudge added this to the v11.16.1 milestone Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants