Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pagination and tests for Client Grants #116

Merged
merged 2 commits into from
Jul 10, 2018

Conversation

joshcanhelp
Copy link
Contributor

@joshcanhelp joshcanhelp commented Jul 5, 2018

  • Add page and per_page parameters to Auth0::Api::V2::ClientGrants::client_grants endpoint
  • Add unit and integration tests for this change
  • Remove sleep directives from the client grant integration tests

def client_grants (page: nil, per_page: nil)
request_params = {
page: !page.nil? ? page.to_i : nil,
per_page: !page.nil? && !per_page.nil? ? per_page.to_i : nil
Copy link

@machuga machuga Jul 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to simplify this down to page.nil? || per_page.nil? ? nil : per_page.to_i. There are a lot of symbols going on already, so reducing the cognitive overhead of negated ANDs should help reduce the complexity.

I'll also add that if anyone drops in a boolean to these params, the method will raise since to_i is not implemented on booleans. I'm assuming this logic exists just to cast strings to ints though. And some of the logic seems confusing to read through. Here is a potential alternative to the method that I'm not sure I like any better, but 🤷‍♂️.

def client_grants(page: nil, per_page: nil)
  return get(client_grants_path) if page.nil?

  clean_per_page = per_page.nil? ? nil : per_page.to_i

  get(client_grants_path, page: page.to_i, per_page: clean_per_page) 
end

It explicitly shows that if page is nil we have nothing to do here, then continues on with the logic.

Ideally you could get rid of the last ternary if the logic of passing per_page supports it, but that's something you'd have to check out.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good feedback, thank you. I'll see if I can simplify this a little better in a new commit.

@joshcanhelp
Copy link
Contributor Author

@machuga - Removed casting here since it was not doing anything (string values passed were still returning the correct results)

Copy link

@machuga machuga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@joshcanhelp joshcanhelp merged commit 97f06b1 into master Jul 10, 2018
@joshcanhelp joshcanhelp deleted the add-pagination-client-grants branch July 10, 2018 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants