Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Management API Roles endpoints #172

Merged
merged 6 commits into from
Jun 26, 2019
Merged

Add Management API Roles endpoints #172

merged 6 commits into from
Jun 26, 2019

Conversation

joshcanhelp
Copy link
Contributor

Changes

  • Add all Roles endpoints for the Management API
  • Fix Users permission arrays

Testing

Integration tests for these changes and #169 will be added in another PR

  • This change adds unit test coverage
  • This change has been tested on the latest version of Ruby (2.6.0)

Checklist

  • All existing and new tests complete without errors
  • Rubocop passes on all added/modified files
  • All active GitHub checks have passed

@joshcanhelp joshcanhelp requested a review from a team June 26, 2019 22:39
@joshcanhelp joshcanhelp added this to the v4.8.0 milestone Jun 26, 2019
@joshcanhelp joshcanhelp merged commit f8a2182 into master Jun 26, 2019
@joshcanhelp joshcanhelp deleted the add-roles-endpoints branch June 26, 2019 23:50
This was referenced Jun 27, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damieng damieng damieng approved these changes

Assignees
No one assigned
Labels
CH: Added
Projects
None yet
Milestone
v4.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@joshcanhelp @damieng