Add Roles and Users endpoints integration tests #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshcanhelp
changed the title
joshcanhelp
force-pushed
the
add-roles-and-users-integration-tests
branch
from
6170d8a to
579cf77
Compare
joshcanhelp
force-pushed
the
add-roles-and-users-integration-tests
branch
from
579cf77 to
7ff2375
Compare
joshcanhelp
changed the title
joshcanhelp
force-pushed
the
add-roles-and-users-integration-tests
branch
from
7ff2375 to
6278b66
Compare
lbalmaceda
approved these changes
Jul 2, 2019
| @@ -220,19 +221,19 @@ def remove_user_roles(user_id, roles) | |||
| raise Auth0::MissingUserId, 'Must supply a valid user_id' if user_id.to_s.empty? | |||
| validate_strings_array roles | |||
| path = "#{users_path}/#{user_id}/roles" | |||
| delete(path, { roles: roles }) | |||
| delete_with_body path, roles: roles | |||
There was a problem hiding this comment.
I see inconsistencies on the syntax when calling a function with parameters.
delete(path, {param: value} vs delete path, param:value.
Should we add a linter as a precommit for this repo as well or is this change on purpose?
There was a problem hiding this comment.
There is a linter that I run, rubocop, but it doesn't pick this up
| @@ -20,6 +20,8 @@ module HTTPProxy | |||
| call(:get, url(safe_path), timeout, get_headers) | |||
| elsif method == :delete | |||
| call(:delete, url(safe_path), timeout, add_headers({params: body})) | |||
There was a problem hiding this comment.
what is this params:body header for? I guess you meant to send a query instead?
There was a problem hiding this comment.
Oddly, sending it as params: converts it to a query ... one of the many quirks of this HTTP library
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
unlink_users_accounttounlink_user_account, added alias and testdelete_with_bodymethod to send a body rather than params with aDELETErequestNote for reviewers:
spec/fixtures/vcr_cassettes/Auth0_Api_V2_Users/andspec/fixtures/vcr_cassettes/Auth0_Api_V2_Roles/. Sensitive information (API token) is automatically filtered out.API_TOKEN).References
Testing